contracts: implement calldata encryption in Solidity #436
Conversation
✅ Deploy Preview for oasisprotocol-sapphire-paratime ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| ); | ||
|
|
||
| return | ||
| abi.encodePacked( |
There was a problem hiding this comment.
I suspect the output bytecode for this is going to be huge
| expect(parsedCborUint).eq(MAX_SAFE_UINT128); | ||
| expect(newOffset).eq(16 + 1); | ||
|
|
||
| //expect(await contract.testUintRoundtrip(MAX_SAFE_UINT128)).eq(true); |
There was a problem hiding this comment.
CBOR encoding integers larger than 64bit seems to vary between libraries, some use tagging, others don't.
There was a problem hiding this comment.
Not a blocker right. I'm sure we'll get dev feedback if this is buggy?
| expect(parsedCborUint).eq(MAX_SAFE_UINT128); | ||
| expect(newOffset).eq(16 + 1); | ||
|
|
||
| //expect(await contract.testUintRoundtrip(MAX_SAFE_UINT128)).eq(true); |
There was a problem hiding this comment.
Not a blocker right. I'm sure we'll get dev feedback if this is buggy?
| if (len > 0x20) revert CBOR_Error_InvalidLength(len); | ||
|
|
||
| assembly { | ||
| value := mload(add(add(0x20, result), offset)) |
There was a problem hiding this comment.
This loads a 256bit word from an offset of a byte array, the first 256bits of the byte array is the length prefix, which is skipped.
There was a problem hiding this comment.
Ah, I see. Maybe add a comment?
| value := mload(add(add(0x20, result), offset)) | |
| // Load value from the result array at position 32+offset. | |
| value := mload(add(add(0x20, result), offset)) |
|
Unfortunately splitting a small PR into lots of even smaller minor PRs is also very tedious. I can re-commit them as individual commits within the PR (that would be slightly less tedious)? |
| ); | ||
| } | ||
|
|
||
| function encryptCallData(bytes memory in_data) |
There was a problem hiding this comment.
Please document this and add a short example similar to other functions in Sapphire.sol.
| // OPAD ^ IPAD, (OPAD = 0x5c) | ||
| bytes32 constant HMAC_OPAD_XOR_IPAD = 0x6a6a6a6a6a6a6a6a6a6a6a6a6a6a6a6a6a6a6a6a6a6a6a6a6a6a6a6a6a6a6a6a; | ||
|
|
||
| function HMAC_sha512_256(bytes memory key, bytes memory message) |
There was a problem hiding this comment.
Please document this and add a short example similar to other functions in Sapphire.sol.
| constructor() payable { // solhint-disable-line | ||
| // Do nothing, but allow balances to be sent on construction. | ||
| } |
There was a problem hiding this comment.
Does this work? Same below.
| constructor() payable { // solhint-disable-line | |
| // Do nothing, but allow balances to be sent on construction. | |
| } | |
| // Do nothing, but allow balances to be sent on construction. | |
| constructor() payable {} |
Fixes: #428
subcall_staticto perform subcall withstaticcall, makes several Subcall methodsviewnonceto Cipher for encryption (useful for tests & reproducibility)Re: CBOR, I split the CBOR related stuff into individual functions, as otherwise you start needing to deploy the whole
CBORlibrary on its own an link it into a library, whereas using individual function they get pulled in as & when necessary.