Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contracts/generateSigningKeypair: Doc explicit sk size #437

Merged
merged 1 commit into from
Oct 15, 2024
Merged

contracts/generateSigningKeypair: Doc explicit sk size #437

merged 1 commit into from
Oct 15, 2024

Conversation

matevz
Copy link
Member

@matevz matevz commented Oct 14, 2024

Fixes #430

@netlify Netlify
Copy link

netlify bot commented Oct 14, 2024 •
edited
Loading

✅ Deploy Preview for oasisprotocol-sapphire-paratime canceled.

Name Link
🔨 Latest commit b27603d
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-sapphire-paratime/deploys/670e4bd5b5ed570008345659

@matevz matevz marked this pull request as draft October 14, 2024 13:17
@matevz matevz force-pushed the matevz/fix/docs-sapphire-contracts-keypair-size branch from 9f5aa5a to 74e7c76 Compare October 14, 2024 13:19
@matevz matevz marked this pull request as ready for review October 14, 2024 13:20
@matevz matevz requested a review from CedarMist October 14, 2024 13:20
CedarMist
CedarMist requested changes Oct 15, 2024
View reviewed changes
Copy link
Member

@CedarMist CedarMist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With P384 the public/secret key sizes will be larger than 33 bytes, but follows the same encoding as other non-Edwards curves.

P384 = 49 bytes encoded (48 + 1 byte prefix)

Gas cost for P384:

  • Keygen: 18000
  • Sign: 43200
  • Verify: 37920

@matevz matevz force-pushed the matevz/fix/docs-sapphire-contracts-keypair-size branch from 74e7c76 to b27603d Compare October 15, 2024 11:02
@matevz
Copy link
Member Author

matevz commented Oct 15, 2024

With P384 the public/secret key sizes will be larger than 33 bytes, but follows the same encoding as other non-Edwards curves.

P384 = 49 bytes encoded (48 + 1 byte prefix)

Gas cost for P384:

* Keygen: 18000

* Sign: 43200

* Verify: 37920

Thanks, added P384 gas costs.

@matevz matevz merged commit 52b7266 into main Oct 15, 2024
10 checks passed
@matevz matevz deleted the matevz/fix/docs-sapphire-contracts-keypair-size branch October 15, 2024 13:03
github-actions bot added a commit that referenced this pull request Oct 15, 2024
@github-actions
Deploy js API reference Merge pull request #437 from oasisprotocol/ma…
e8c4a86 
…tevz/fix/docs-sapphire-contracts-keypair-size

contracts/generateSigningKeypair: Doc explicit sk size 52b7266
github-actions bot added a commit that referenced this pull request Oct 15, 2024
@github-actions
Deploy sol API reference Merge pull request #437 from oasisprotocol/m…
22c1ead 
…atevz/fix/docs-sapphire-contracts-keypair-size

contracts/generateSigningKeypair: Doc explicit sk size 52b7266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CedarMist CedarMist CedarMist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Describe length of Sapphire.generateSigningKeyPair private key
2 participants
@matevz @CedarMist