Merge pull request #1775 from oasisprotocol/lw/playwright-todo

Revert TODOs from "Avoid playwright's buggy test.fail() skipping tests"
oasisprotocol · Nov 27, 2023 · 0f0b432 · 0f0b432
2 parents d45d397 + 6f159de
commit 0f0b432
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.changelog/1775.internal.md b/.changelog/1775.internal.md
@@ -0,0 +1 @@
+Revert TODOs from "Avoid playwright's buggy test.fail() skipping tests"
diff --git a/playwright/tests/fiat.spec.ts b/playwright/tests/fiat.spec.ts
@@ -60,7 +60,7 @@ test.describe('Fiat on-ramp', () => {
   test('Content-Security-Policy should block unknown iframe and fail', async ({ page }) => {
     test.fail()
     expect((await page.request.head('/')).headers()).toHaveProperty('content-security-policy')
-    // await expectNoErrorsInConsole(page) // TODO: revert when playwright doesn't skip other tests because of this
+    await expectNoErrorsInConsole(page)
     await setup(page)
     await page.route('https://*.transak.com/*', route =>
       route.fulfill({ status: 301, headers: { Location: 'https://phishing-transak.com/' } }),
@@ -79,7 +79,7 @@ test.describe('Fiat on-ramp', () => {
 
   test('Sandbox should block top-navigation from iframe and fail', async ({ page }) => {
     test.fail()
-    // await expectNoErrorsInConsole(page) // TODO: revert when playwright doesn't skip other tests because of this
+    await expectNoErrorsInConsole(page)
     await setup(page)
     await page.route('https://*.transak.com/*', route =>
       route.fulfill({