Filter runtime txs when fetching detailed txs

oasisprotocol · Jul 11, 2024 · 756d0b8 · 756d0b8
1 parent fafb9ca
commit 756d0b8
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/.changelog/1999.internal.md b/.changelog/1999.internal.md
@@ -0,0 +1 @@
+Filter runtime txs when fetching detailed txs
diff --git a/src/app/state/account/saga.ts b/src/app/state/account/saga.ts
@@ -57,7 +57,17 @@ export function* fetchAccount(action: PayloadAction<string>) {
           })
 
           const detailedTransactions = yield* call(() =>
-            Promise.allSettled(transactions.map(({ hash }) => getTransaction({ hash }))),
+            Promise.allSettled(
+              transactions.map(tx => {
+                const { hash, runtimeId, runtimeName, round } = tx
+
+                if (!!runtimeId || !!runtimeName || !!round) {
+                  return Promise.reject()
+                }
+
+                return getTransaction({ hash })
+              }),
+            ),
           )
           const transactionsWithUpdatedNonce = transactions.map((t, i) => {
             const { status, value } = detailedTransactions[i] as PromiseFulfilledResult<Transaction>

diff --git a/src/app/state/transaction/types.ts b/src/app/state/transaction/types.ts
@@ -49,12 +49,12 @@ export interface Transaction {
   timestamp: number | undefined
   to: string | undefined
   type: TransactionType
+  nonce: StringifiedBigInt | undefined
   // These are undefined on consensus transaction
   // Only appear on ParaTime transaction
   runtimeName: string | undefined
   runtimeId: string | undefined
   round: number | undefined
-  nonce: StringifiedBigInt | undefined
 }
 
 /* --- STATE --- */