Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't shuffle inactive validators to the top #1608

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Aug 23, 2023

Fixes #1517

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 23, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ac4906d
Status: ✅  Deploy successful!
Preview URL: https://efe90d5d.oasis-wallet.pages.dev
Branch Preview URL: https://lw-shuffle-active.oasis-wallet.pages.dev

View logs

@github-actions
Copy link

github-actions bot commented Aug 23, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 6 0 0.05s
✅ REPOSITORY checkov yes no 40.54s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 13.93s
✅ REPOSITORY trivy-sbom yes no 2.17s
✅ REPOSITORY trufflehog yes no 146.75s
✅ TYPESCRIPT eslint 3 0 0 6.24s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #1608 (0ff15f5) into master (1e99434) will not change coverage.
The diff coverage is 85.71%.

❗ Current head 0ff15f5 differs from pull request most recent head ac4906d. Consider uploading reports for the commit ac4906d to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1608   +/-   ##
=======================================
  Coverage   83.01%   83.01%           
=======================================
  Files         157      157           
  Lines        4073     4073           
  Branches      730      730           
=======================================
  Hits         3381     3381           
  Misses        692      692           
Flag Coverage Δ
cypress 51.23% <20.00%> (ø)
jest 78.03% <85.71%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/app/state/staking/index.ts 90.90% <75.00%> (+0.58%) ⬆️
src/app/state/staking/saga.ts 87.91% <100.00%> (-0.26%) ⬇️

Shuffling in reducer doesn't break tests on fallback validators.
Fixes 1ff127b shuffling inactive validators to the top.
@lukaw3d lukaw3d enabled auto-merge August 24, 2023 11:58
@lukaw3d lukaw3d merged commit b800969 into master Aug 24, 2023
11 checks passed
@lukaw3d lukaw3d deleted the lw/shuffle-active branch August 24, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants