Add transaction detail API cache #1979
Merged
+40
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
lubej
force-pushed
the
ml/cache-tx-detail
branch
from
09543ca
to
48a691b
Compare
This was referenced Jun 19, 2024
Merged
lubej
force-pushed
the
ml/cache-tx-detail
branch
2 times, most recently
from
3171098
to
8652661
Compare
lubej
requested review from
lukaw3d and
buberdds
and removed request for
lukaw3d
lukaw3d
approved these changes
Jul 10, 2024
lukaw3d
reviewed
Jul 10, 2024
lubej
force-pushed
the
ml/cache-tx-detail
branch
3 times, most recently
from
34e91e5
to
658b603
Compare
- as /chain/transaction/{hash} endpoint response won't change, cache it
lubej
force-pushed
the
ml/cache-tx-detail
branch
from
658b603
to
393024e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds cache for the following 2 endpoints:
/chain/transaction/{hash})/runtime/transaction/info?id={paraTimeId}&hash={hash})As those responses won't change, once indexed, they are cached through the app session(until user closes the wallet).