Add information on leadership changes to oban.peer.election
event
#1148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at including whether Oban leadership changed in the
oban.peer.election
I added the key
was_leader
, which indicates if the current node was the leader before the election happened.If
was_leader=false
andleader=true
in a telemetry event, then we know that the current node just became the leader. Ifwas_leader=true
andleader=false
then we know that the current node lost leadership.Marking this as a draft because I haven't tested it out yet in my application. I think I can add some tests to
test/oban/peers/postgres_test.exs
andtest/oban/peers/global_test.exs
too. That seems to be where this telemetry event gets tested.Also, lmk if you'd prefer a different name.