Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.

Enable all necessary tests #219

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Enable all necessary tests #219

merged 1 commit into from
Oct 16, 2023

Conversation

c71n93
Copy link
Member

@c71n93 c71n93 commented Oct 16, 2023

Closes #215


PR-Codex overview

The focus of this PR is to update the failed output messages in the Hamcrest tests.

Detailed summary:

  • Updated the assert-that statements with @ as the suggestion object
  • Updated the expected values in the equal-to conditions for various tests
  • Removed the nop objects from the tests
  • Added a new version to the arrays-matchers-tests.eo file

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@c71n93
Copy link
Member Author

c71n93 commented Oct 16, 2023

@maxonfjvipon could you check this one, please?

Copy link
Member

@maxonfjvipon maxonfjvipon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c71n93 LGTM! Thanks

@c71n93
Copy link
Member Author

c71n93 commented Oct 16, 2023

@yegor256 have a look, please

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Oct 16, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 8c1647a into objectionary:master Oct 16, 2023
8 checks passed
@rultor
Copy link
Contributor

rultor commented Oct 16, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 4min)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arrays-matchers-tests.eo:30-37: Enable the tests when...
5 participants