Merge pull request #3241 from c71n93/2251-fixing-sonar-violations

Fix sonar reliability issues

eo-maven-plugin/src/main/java/org/eolang/maven/dependencies/DcsFake.java

@@ -95,7 +95,7 @@ static Dependency randDep(final String scope) {
         return DcsFake.dep(
             UUID.randomUUID().toString(),
             UUID.randomUUID().toString(),
-            String.valueOf(Math.abs(rand.nextInt())),
+            String.valueOf(rand.nextInt(Integer.MAX_VALUE)),
             scope
         );
     }
@@ -125,7 +125,7 @@ private static Dependency randDep() {
         return DcsFake.dep(
             UUID.randomUUID().toString(),
             UUID.randomUUID().toString(),
-            String.valueOf(Math.abs(rand.nextInt())),
+            String.valueOf(rand.nextInt(Integer.MAX_VALUE)),
             scope
         );
     }

eo-maven-plugin/src/main/java/org/eolang/maven/name/OnDefault.java

@@ -60,7 +60,7 @@ public String value() {
 
     @Override
     public CommitHash hash() {
-        return new CommitHash.ChConstant(this.name.label().get());
+        return new CommitHash.ChConstant(this.name.label().orElse(""));
     }
 
     @Override

eo-maven-plugin/src/test/java/org/eolang/maven/PullMojoTest.java

@@ -295,27 +295,26 @@ void doesNotPullInOfflineMode(@TempDir final Path tmp) throws IOException {
 
     @Test
     @CaptureLogs
-    void showsWhereNotFoundWasDiscoveredAt(@TempDir final Path tmp, final Logs out) {
+    void showsWhereNotFoundWasDiscoveredAt(@TempDir final Path tmp, final Logs out)
+        throws IOException {
+        final FakeMaven mvn = new FakeMaven(tmp)
+            .withProgram(
+                "+package com.example\n",
+                "# This is the default 64+ symbols comment in front of named abstract object.",
+                "[] > main",
+                "  org.eolang.org > @"
+            )
+            .with(
+                "objectionaries",
+                new Objectionaries.Fake(
+                    new OyRemote(
+                        new ChRemote("master")
+                    )
+                )
+            );
         Assertions.assertThrows(
             Exception.class,
-            () -> {
-                new FakeMaven(tmp)
-                    .withProgram(
-                        "+package com.example\n",
-                        "# This is the default 64+ symbols comment in front of named abstract object.",
-                        "[] > main",
-                        "  org.eolang.org > @"
-                    )
-                    .with(
-                        "objectionaries",
-                        new Objectionaries.Fake(
-                            new OyRemote(
-                                new ChRemote("master")
-                            )
-                        )
-                    )
-                    .execute(new FakeMaven.Pull());
-            },
+            () -> mvn.execute(new FakeMaven.Pull()),
             "Pull mojo should fail, but it does not"
         );
         Assertions.assertTrue(

eo-runtime/src/main/java/org/eolang/Dataized.java

@@ -50,11 +50,21 @@ public final class Dataized {
 
     /**
      * Dataization level.
+     *
+     * @todo #2251:90min It is necessary to call {@link ThreadLocal#remove()} on
+     *  {@link Dataized#LEVEL} variables to prevent memory leaks. We should either find a place
+     *  where this variable can be removed, or, if this is not possible
+     *  (see https://github.com/objectionary/eo/pull/1930), come up with another solution.
      */
     private static final ThreadLocal<Integer> LEVEL = ThreadLocal.withInitial(() -> 0);
 
     /**
      * Max dataization level.
+     *
+     * @todo #2251:90min It is necessary to call {@link ThreadLocal#remove()} on
+     *  {@link Dataized#MAX_LEVEL} variables to prevent memory leaks. We should either find a place
+     *  where this variable can be removed, or, if this is not possible
+     *  (see https://github.com/objectionary/eo/pull/1930), come up with another solution.
      */
     private static final ThreadLocal<Integer> MAX_LEVEL =
         ThreadLocal.withInitial(() -> Integer.getInteger("max.dataization.log", 3));

eo-runtime/src/main/java/org/eolang/PhDefault.java

@@ -61,6 +61,11 @@ public class PhDefault implements Phi, Cloneable {
 
     /**
      * Attributes nesting level.
+     *
+     * @todo #2251:90min It is necessary to call {@link ThreadLocal#remove()} on
+     *  {@link PhDefault#NESTING} to prevent memory leaks. We should either find a place where this
+     *  variable can be removed, or, if this is not possible
+     *  (see https://github.com/objectionary/eo/pull/1930), come up with another solution.
      */
     private static final ThreadLocal<Integer> NESTING = ThreadLocal.withInitial(() -> 0);
 

eo-runtime/src/main/java/org/eolang/PhPackage.java

@@ -102,6 +102,7 @@ public Phi take(final String name) {
         } else {
             res = new AtSetRho(this.objects.get().get(key), this, key).get();
         }
+        this.objects.remove();
         return res;
     }
 

eo-runtime/src/main/java/org/eolang/PhTraced.java

@@ -46,6 +46,11 @@ public final class PhTraced implements Phi {
     /**
      * Cages that are currently being dataized. If one cage is being datazed, and
      * it needs to be dataized inside current dataization, the locator of current object be here.
+     *
+     * @todo #2251:90min It is necessary to call {@link ThreadLocal#remove()} on
+     *  {@link PhTraced#DATAIZING_CAGES} to prevent memory leaks. We should either find a
+     *  place where this variable can be removed, or, if this is not possible
+     *  (see https://github.com/objectionary/eo/pull/1930), come up with another solution.
      */
     private static final ThreadLocal<Map<Integer, Integer>> DATAIZING_CAGES = ThreadLocal
         .withInitial(HashMap::new);