-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate concise Java code for tests #1249
Comments
@yegor256 please assisgn |
@mximp I think we can stay with inner objects, but do something with their names. Why not? |
@Graur please, help with this one |
@yegor256 The issues is that it's Java compiler who is generating the names for inner classes: it prepends inner class name with the outer classes. No matter what names we pick for them with certain level of nesting the compiler will produce long enough
So the only solution I see here is to avoid nesting... Or at least nest classes into the same outer not into each other so we have names like: |
@mximp got it. I like the second option: keep all classes in the same file, but reposition them to avoid nesting. |
@mximp let's do this? |
@Graur I believe it was with you. |
@maxonfjvipon please assign me |
#1249: It should align inner classes in tests
When
+junit
exists in eo code separate mechanism of Java code generation is enabled. It's driven byjunit.xsl
andrename-junit-inners.xsl
. It generates inner Java classes for each inner EO object which leads to long class names during Java compilation.The only option is to re-design how we generate Java code for tests.
Probably we need to generate normal (not inner) Java class for each object just like it's done for normal objects.
The text was updated successfully, but these errors were encountered: