Batch fix sonarqube failures #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yegor256 please reveiw |
yegor256
reviewed
Mar 21, 2023
| * This includes call of {@link ThreadLocal#remove()} method to prevent | ||
| * memory leaks. | ||
| */ | ||
| public static void cleanUp() { |
There was a problem hiding this comment.
@mximp I don't see anyone calling this method. I think, remove() is supposed to be called right after we use TERMS, not in a separate method. But I'm not sure...
There was a problem hiding this comment.
@yegor256 You are right - the method is not called by anyone. The thing is I cannot define the moment "right after TERM is used". It's static and holds the value which is required throughout the program execution. So I see correct place for remove to be called before program exits. But that doesn't make sense.
So in this case I just created fake method according to SonarQube expectations.
There was a problem hiding this comment.
@yegor256 From this post it is still not clear how to apply in our case. According to Java Docs:
Removes the current thread's value for this thread-local variable. If this thread-local variable is subsequently read by the current thread, its value will be reinitialized by invoking its initialValue() method, unless its value is set by the current thread in the interim. This may result in multiple invocations of the initialValue method in the current thread.
Which means that if we call this method on TERM it will be reset, i.e. cache of the vertexes will be cleared. Which is not what we want. It would make sense if we have clear lifecycle of a thread.. But "end-of-thread"/"end-of-processing" is not identifiable in our case.
PR Summary
|
|
@yegor256 please check my comment #1930 (comment) |
|
@yegor256 reminder |
|
@rultor merge |
@mximp @yegor256 Oops, I failed. You can see the full log here (spent 2hr) |
TldrThis PR introduces some improvements, fixes and code refactorings for the eo-maven-plugin and eo-parser. Detailed summary
|
|
@yegor256 please try again |
|
@rultor merge |
@mximp @yegor256 We failed, sorry, try again: |
|
@yegor256 please merge |
|
@rultor merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1897 Fixes of SonarCloud findings.
Add puzzles for the rest.