2390 #3090
2390 #3090
Conversation
|
@maxonfjvipon @volodya-lombrozo reminder |
There was a problem hiding this comment.
@l3r8yJ Thank you for the contribution! Could you please make this puzzle more understandable? Imagine newcomers joining project: they should understand what's going on and what they have to do to implement this puzzle by reading the puzzle description.
| * - implementation – just includes the dependency for inner usage | ||
| * - api – allows to users of API to | ||
| * use dependency which was added to project via `api` keyword | ||
| * <p/><a href="https://shorturl.at/abns4">More about api and implementation here</a> |
There was a problem hiding this comment.
@l3r8yJ Does this link actually lead somewhere? I can't open it.
| * multiple threads and check that the method works correctly without exceptions. | ||
| * We can apply the same approach as mentioned in that post: | ||
| * <a href="https://www.yegor256.com/2018/03/27/how-to-test-thread-safety.html">Post</a> | ||
| * @todo #2375:90min. Implement mechanism for "inner" and "outer" classes. |
There was a problem hiding this comment.
@l3r8yJ To be honest, I didn't clearly understand what you want to do in this puzzle.
First of all. Do you want to "get rid of the TranspileMojo#cleanUpClasses method?" If it is so, it would be nice to put this phrase as a header of the puzzle:
@todo #2375:90min. Get rid of the TranspileMojo#cleanUpClasses method.
Second, it would be nice to answer the "why?" question. Why do we need to do it at all?
@todo #2375:90min. Get rid of the TranspileMojo#cleanUpClasses method.
We need to remove it because ...
Third, you can suggest some ideas about the possible solutions of the problem you already mentioned.
@todo #2375:90min. Get rid of the TranspileMojo#cleanUpClasses method.
We need to remove it because ...
To do so, we can...
However, these are only my suggestions, and you can do it as you want. But please, make this puzzle a bit more understandable.
BTW, I didn't clearly understand what "inner" and "outer" classes mean.
|
@volodya-lombrozo I made some clarifications based on your review. Also for better understanding of the term |
| * multiple threads and check that the method works correctly without exceptions. | ||
| * We can apply the same approach as mentioned in that post: | ||
| * <a href="https://www.yegor256.com/2018/03/27/how-to-test-thread-safety.html">Post</a> | ||
| * @todo #2375:90min. Implement a mechanism for "internal" and "external" classes. |
There was a problem hiding this comment.
@l3r8yJ, could you please provide more context? Imagine someone opening this issue in the future; they should be able to understand what to do at first glance:
- I still don't understand why we might need "internal" and "external" classes, or why we need to implement them.
- Why should "internal" classes be included in the catalog?
- Which specific catalog are you referring to?
- Why should "external" classes be placed in a different directory?
- Are "catalog" and "directory" the same entities in this context?
@l3r8yJ Example: Let's imagine a group of developers of the Now, imagine you are trying to build another library that uses This is a problem that is sometimes hard to identify. So we "clean" these dirty classes, which actually just hides the problem. |
|
@volodya-lombrozo so, might be this issue can be resolved with some plugin, which will validate project on |
|
@l3r8yJ, I believe we should have protection on both sides, in our compiler and during the building of libraries. I'm afraid that creating a new plugin might be some sort of overengineering. But I like the idea of libraries validation. |
@maxonfjvipon @volodya-lombrozo take a look, please
closes #2390
PR-Codex overview
This PR enhances
TranspileMojoby implementing a mechanism for distinguishing "internal" and "external" classes, inspired by Gradle'simplementationandapiconcepts.Detailed summary
implementationandapifor dependencies