Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3091 Bytecode modifications for object versioning. Pre-Employment Te… #3186

Conversation

SevyConst
Copy link

@SevyConst SevyConst commented May 13, 2024

#3091 Bytecode modifications for object versioning. Pre-Employment Test (Konstantin Lopatko)

As you asked, what has been done at the current moment.

  • Add ASM library. You are already using it inside ByteBuddy (Mockito dependency)
  • Integration test is ready except code style.
  • Bytecode modification works as described in the issue

What I plan to do later:

  • Add some annotations to the Mojo (and maybe some other miscellaneous thing)
  • Check the Mojo with relative paths (parameters of the Mojo)
  • Write a test or enhance the integration test by checking usage local variable which is instance of @Versionized class. I have already tested it manually - the bytecode modifications works as required
  • Maybe add some other test cases for the integration test
  • Add some unit tests

PR-Codex overview

This PR adds versionized annotations to classes and interfaces in the project. It also includes new dependencies for ASM library version 9.7.

Detailed summary

  • Added versionized annotations to classes and interfaces
  • Introduced ASM library dependencies version 9.7

The following files were skipped due to too many changes: eo-maven-plugin/src/test/resources/org/eolang/maven/bytecode-modification/java-files/org/eolang/Versionized.java, eo-maven-plugin/src/main/java/org/eolang/maven/ModifyBytecodeMojo.java, eo-maven-plugin/src/test/java/org/eolang/maven/ModifyBytecodeMojoTest.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

…mployment Test (Konstantin Lopatko)

Preview - what has been done at the current moment.

- Add ASM library. You are already using it inside ByteBuddy (Mockito dependency)
- Integration test is ready except code style.
- Bytecode modification works as described in the issue
@maxonfjvipon
Copy link
Member

@SevyConst thanks for you PR. To start review we need all GHA jobs are green first. If you need help - I'm ready

@yegor256
Copy link
Member

yegor256 commented Oct 3, 2024

@SevyConst what's up with this one? Will you make it ready for merge or we can close it?

@SevyConst
Copy link
Author

You can close it

@yegor256 yegor256 closed this Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants