Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#3195): PhiMojo skips failed #3196

Merged

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented May 22, 2024

Ref: #3195


PR-Codex overview

The focus of this PR is to enhance the PhiMojo functionality by adding options to control critical error behavior and skipping failed files.

Detailed summary

  • Added phiFailOnCritical and phiSkipFailed parameters to control critical error behavior.
  • Added tests for phiFailOnCritical and phiSkipFailed functionalities.
  • Updated PhiMojo to handle critical errors and skip failed files accordingly.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

@yegor256 please check

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented May 22, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 6bf2062 into objectionary:master May 22, 2024
21 checks passed
@rultor
Copy link
Contributor

rultor commented May 22, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 22min)

@volodya-lombrozo
Copy link
Member

@yegor256 Could you release a new version, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants