Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid sonar warning related to other version of java #3197

Merged
merged 1 commit into from
May 23, 2024

Conversation

c71n93
Copy link
Member

@c71n93 c71n93 commented May 22, 2024

Related to #2251

The problem was with this sonar check. This problem should not have occurred, because in our project we use the java 8 version, but the close method in the ExecutorService is implemented only in java 19.

Before I tried to change java version using sonar.java.source (#2900) but it didn't help.

According to this issue the only way to make analysis work for specific java version is to use jdk of this particular version.

I tried this on my on my fork of eo and it worked:


PR-Codex overview

This PR updates the Java version from 20 to 17 in the Sonar workflow.

Detailed summary

  • Updated Java version in Sonar workflow from 20 to 17.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@c71n93
Copy link
Member Author

c71n93 commented May 22, 2024

@yegor256 could you check this one, please?

1 similar comment
@c71n93
Copy link
Member Author

c71n93 commented May 23, 2024

@yegor256 could you check this one, please?

@yegor256 yegor256 merged commit 5d21717 into objectionary:master May 23, 2024
21 checks passed
@yegor256
Copy link
Member

@c71n93 thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants