-
-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update npmignore and files package #248
Conversation
0c3630c
to
a051229
Compare
Rebased. |
@vonovak - For the merge, by any change could you use a regular merge? My commit is GPG signed, and I would prefer it not to be rewritten on the GitHub server (or having to force delete my local branch). I just rebased my branch onto the latest |
This doesn't include some pretty important files like the |
a051229
to
cf6d101
Compare
@oblador - |
OK, fair enough, i'll give it a try myself too then. Any reason we can't get rid of the |
cf6d101
to
d9bbd7f
Compare
@oblador - Great question. Because of the typical setup of a RN library that contains nested app project the dependency resolution with Yarn may be tricky. There is some inconsistency in the way RN library example projects include the library they're showcasing (some use a NPM reference, some a relative path, some other babel/metro hacks). It is true that with the current setup the npmignore file could be removed. I have some local changes with other updates that might require the file to be re-added though. In order to avoid that I kept it for now. We can always fully remove it later. Please let me know if this is okay. |
Thanks for the explanation, I think this sounds good :) |
A quick update to
.npmignore
and thefiles
section inpackage.json
that reduces the distribution artifact size by more than 70% (mainly by no longer including Gradle wrapper, which is not used by app consumers).Before:
After:
CC @SaeedZhiany