-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RN-0.73 change Android configs for RN 0.73 compatibility #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added back the namespace to AndroidManifest to keep previous RN compatible |
saltire
approved these changes
Jul 12, 2023
2 tasks
oblador
approved these changes
Jul 17, 2023
Closed
hyochan
referenced
this pull request
in dooboolab-community/dooboo-ui
Jul 17, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-vector-icons](https://togithub.com/oblador/react-native-vector-icons) | [`^9.2.0` -> `^10.0.0`](https://renovatebot.com/diffs/npm/react-native-vector-icons/9.2.0/10.0.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-vector-icons/10.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-vector-icons/10.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-vector-icons/9.2.0/10.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-vector-icons/9.2.0/10.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>oblador/react-native-vector-icons (react-native-vector-icons)</summary> ### [`v10.0.0`](https://togithub.com/oblador/react-native-vector-icons/releases/tag/v10.0.0): 10.0.0 [Compare Source](https://togithub.com/oblador/react-native-vector-icons/compare/v9.2.0...v10.0.0) #### Overview - Improved support for React Native 0.72, 0.73 and RN Web. - New and updated icon sets. #### Detailed Changes - Fix link to FontAwesome website by [@​nidelson](https://togithub.com/nidelson) in [https://github.com/oblador/react-native-vector-icons/pull/1444](https://togithub.com/oblador/react-native-vector-icons/pull/1444) - Upgrade example to React Native 0.70 by [@​oblador](https://togithub.com/oblador) in [https://github.com/oblador/react-native-vector-icons/pull/1467](https://togithub.com/oblador/react-native-vector-icons/pull/1467) - Migrate to new architecture by [@​oblador](https://togithub.com/oblador) in [https://github.com/oblador/react-native-vector-icons/pull/1468](https://togithub.com/oblador/react-native-vector-icons/pull/1468) - Remove setNativeProps by [@​oblador](https://togithub.com/oblador) in [https://github.com/oblador/react-native-vector-icons/pull/1469](https://togithub.com/oblador/react-native-vector-icons/pull/1469) - Upgrade example to React Native 0.72 by [@​oblador](https://togithub.com/oblador) in [https://github.com/oblador/react-native-vector-icons/pull/1517](https://togithub.com/oblador/react-native-vector-icons/pull/1517) - fix: make `lintVitalAnalyze*` depend on copy by [@​msbit](https://togithub.com/msbit) in [https://github.com/oblador/react-native-vector-icons/pull/1515](https://togithub.com/oblador/react-native-vector-icons/pull/1515) - Update README.md by [@​aniketjha9179](https://togithub.com/aniketjha9179) in [https://github.com/oblador/react-native-vector-icons/pull/1502](https://togithub.com/oblador/react-native-vector-icons/pull/1502) - Update README.md by [@​DaduDev](https://togithub.com/DaduDev) in [https://github.com/oblador/react-native-vector-icons/pull/1504](https://togithub.com/oblador/react-native-vector-icons/pull/1504) - Fix to get working with react-native-web by [@​johnf](https://togithub.com/johnf) in [https://github.com/oblador/react-native-vector-icons/pull/1492](https://togithub.com/oblador/react-native-vector-icons/pull/1492) - RN-0.73 change Android configs for RN 0.73 compatibility by [@​felipemillhouse](https://togithub.com/felipemillhouse) in [https://github.com/oblador/react-native-vector-icons/pull/1507](https://togithub.com/oblador/react-native-vector-icons/pull/1507) - Replace tabBarOptions with screenOptions by [@​MenaiAla](https://togithub.com/MenaiAla) in [https://github.com/oblador/react-native-vector-icons/pull/1478](https://togithub.com/oblador/react-native-vector-icons/pull/1478) - fix (ios): support kCTFontManagerErrorDuplicatedName as allowable error by [@​iBotPeaches](https://togithub.com/iBotPeaches) in [https://github.com/oblador/react-native-vector-icons/pull/1474](https://togithub.com/oblador/react-native-vector-icons/pull/1474) - Update README with monorepo info for Android by [@​samzmann](https://togithub.com/samzmann) in [https://github.com/oblador/react-native-vector-icons/pull/1476](https://togithub.com/oblador/react-native-vector-icons/pull/1476) - Improve Error Logging for Font Imports by [@​JKeddo95](https://togithub.com/JKeddo95) in [https://github.com/oblador/react-native-vector-icons/pull/1475](https://togithub.com/oblador/react-native-vector-icons/pull/1475) - Update Ionicons to v7.1.0 by [@​mrkpatchaa](https://togithub.com/mrkpatchaa) in [https://github.com/oblador/react-native-vector-icons/pull/1484](https://togithub.com/oblador/react-native-vector-icons/pull/1484) - Fontawesome6 (Closes [#​1408](https://togithub.com/oblador/react-native-vector-icons/issues/1408)) by [@​johnf](https://togithub.com/johnf) in [https://github.com/oblador/react-native-vector-icons/pull/1483](https://togithub.com/oblador/react-native-vector-icons/pull/1483) - Use Node 16 in CI by [@​oblador](https://togithub.com/oblador) in [https://github.com/oblador/react-native-vector-icons/pull/1518](https://togithub.com/oblador/react-native-vector-icons/pull/1518) - Upgrade Material Icons to Sept 2022 update by [@​oblador](https://togithub.com/oblador) in [https://github.com/oblador/react-native-vector-icons/pull/1519](https://togithub.com/oblador/react-native-vector-icons/pull/1519) - Move ionicon build dependencies to devDependencies by [@​oblador](https://togithub.com/oblador) in [https://github.com/oblador/react-native-vector-icons/pull/1520](https://togithub.com/oblador/react-native-vector-icons/pull/1520) #### New Contributors - [@​nidelson](https://togithub.com/nidelson) made their first contribution in [https://github.com/oblador/react-native-vector-icons/pull/1444](https://togithub.com/oblador/react-native-vector-icons/pull/1444) - [@​msbit](https://togithub.com/msbit) made their first contribution in [https://github.com/oblador/react-native-vector-icons/pull/1515](https://togithub.com/oblador/react-native-vector-icons/pull/1515) - [@​aniketjha9179](https://togithub.com/aniketjha9179) made their first contribution in [https://github.com/oblador/react-native-vector-icons/pull/1502](https://togithub.com/oblador/react-native-vector-icons/pull/1502) - [@​DaduDev](https://togithub.com/DaduDev) made their first contribution in [https://github.com/oblador/react-native-vector-icons/pull/1504](https://togithub.com/oblador/react-native-vector-icons/pull/1504) - [@​johnf](https://togithub.com/johnf) made their first contribution in [https://github.com/oblador/react-native-vector-icons/pull/1492](https://togithub.com/oblador/react-native-vector-icons/pull/1492) - [@​felipemillhouse](https://togithub.com/felipemillhouse) made their first contribution in [https://github.com/oblador/react-native-vector-icons/pull/1507](https://togithub.com/oblador/react-native-vector-icons/pull/1507) - [@​MenaiAla](https://togithub.com/MenaiAla) made their first contribution in [https://github.com/oblador/react-native-vector-icons/pull/1478](https://togithub.com/oblador/react-native-vector-icons/pull/1478) - [@​iBotPeaches](https://togithub.com/iBotPeaches) made their first contribution in [https://github.com/oblador/react-native-vector-icons/pull/1474](https://togithub.com/oblador/react-native-vector-icons/pull/1474) - [@​samzmann](https://togithub.com/samzmann) made their first contribution in [https://github.com/oblador/react-native-vector-icons/pull/1476](https://togithub.com/oblador/react-native-vector-icons/pull/1476) - [@​JKeddo95](https://togithub.com/JKeddo95) made their first contribution in [https://github.com/oblador/react-native-vector-icons/pull/1475](https://togithub.com/oblador/react-native-vector-icons/pull/1475) - [@​mrkpatchaa](https://togithub.com/mrkpatchaa) made their first contribution in [https://github.com/oblador/react-native-vector-icons/pull/1484](https://togithub.com/oblador/react-native-vector-icons/pull/1484) **Full Changelog**: oblador/react-native-vector-icons@v9.2.0...v10.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/dooboolab-community/dooboo-ui). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44LjExIiwidXBkYXRlZEluVmVyIjoiMzYuOC4xMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Hi react-native-keychain also had this issue on [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from React Native v0.73 , all libraries will need to be updated with these two one-liners due to Android Gradle Plugin upgrade
react-native-community/discussions-and-proposals#671
React Native 0.73 will depend on Android Gradle Plugin (AGP) 8.x. This will require all the libraries to specify a namespace in their build.gradle file.
Details
I'd like to share some of the upcoming changes that will happen in 0.73, which is still a bit far, but we'd rather start earlier rather than later.
React Native 0.73 will depend on Android Gradle Plugin (AGP) 8.x, which brings a lot of improvements for Android apps but also a series of notable changes.
Most importantly:
App/Library Developers will now have to install and use Java 17
Library Developers will have to specify a namespace in their build.gradle file.
Specifically, the last change is a breaking change and will make libraries that are not specifying a namespace incompatible with React Native 0.73 (your project won't build).
Support for namespace was added in AGP 7.3.x, which ships with React Native 0.71. Libraries that published a new version with a namespace declared for 0.71 or 0.72 don't need further update. So we invite library authors to do those changes as soon as possible so by the time 0.73 is out, most of the apps are adapted.
What you need to change
Library authors will have to update their
android/build.gradle
file as follows:android { + namespace = "com.iterable.reactnative" ... }
and remove the package definition from their
AndroidManifest.xml
:Further reading
Official Google documentation on namespaces is here.