fix(fonts.gradle): fix react native 0.73 build errors #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjanknoetze
approved these changes
Mar 12, 2024
2 tasks
|
Would be great to see this merged! Manually editing files in |
|
One more vote for merging! |
@sizuf I ended up using |
|
+1 to merge it 👀 |
johnf
approved these changes
Apr 27, 2024
|
@oblador I can't replicate this problem myself, but this seems to fix a problem for lots of folks, and I can't see it doing any harm. Can you merge? |
This was referenced Apr 27, 2024
Rexogamer
approved these changes
Apr 30, 2024
|
This is also affecting me from releasing with the update to RN 0.74. A merge would be really handy as I don't like using patches in production if I can avoid it. The changes in this PR 100% fix the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix build errors on react native 0.73.x version.
This is similar to a previous fix done for 0.72
#1508 (comment)
Commit details: e9cc589