Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTR vaping behavior #198

Merged
merged 2 commits into from
Nov 30, 2023
Merged

NTR vaping behavior #198

merged 2 commits into from
Nov 30, 2023

Conversation

DitchingIt
Copy link
Collaborator

Creates a new term and child relations to tobacco and cannabis vaping as requested in issue #195

Creates a new term and child relations to tobacco and cannabis vaping as requested in issue #195
@DitchingIt DitchingIt self-assigned this Nov 29, 2023
@pmidford
Copy link
Collaborator

Are we still accepting behaviors that are more or less exclusive to humans and occasional model organisms? I thought there was an alternative ontology for these.

@DitchingIt
Copy link
Collaborator Author

Are we still accepting behaviors that are more or less exclusive to humans and occasional model organisms? I thought there was an alternative ontology for these.

Hi @pmidford There aren't yet any plans to deprecate human or animal model behaviours, although it has been discussed. I'm not putting my own efforts into these areas but am happy to encourage others wanting to interact with NBO by helping with the odd thing like a commit, not least where all the thinking has already been done (like here), but you'll note I'm not attempting to impose the styling I'd look for if it was an Ethology edit. Would you be happy to approve this? If OP had made the commit, I would have, but because I wrote it up, GitHub needs someone else.

src/ontology/nbo-edit.owl Outdated Show resolved Hide resolved
Corrected the IRI
@matentzn
Copy link
Collaborator

@matthewhorridge can you review please?

Copy link

@matthewhorridge matthewhorridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. @DitchingIt thanks so much for this and for the really quick turnaround time.

Copy link
Collaborator

@pmidford pmidford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this since we haven't addressed the human specific behavior issue. I didn't know that cannabis vaping was a thing, but as @DitchingIt points out elsewhere, we should avoid terms with singleton children.

@DitchingIt
Copy link
Collaborator Author

@pmidford @matthewhorridge Can someone review and approve the changes I made resolving @matentzn change request? Then I think we're done.

Copy link
Collaborator

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@matentzn matentzn merged commit 7f1107e into master Nov 30, 2023
1 check passed
@matentzn matentzn deleted the Vaping branch November 30, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants