Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the "DOSDP GH workflow"? #2638

Closed
gouttegd opened this issue Oct 10, 2024 · 2 comments
Closed

What is the "DOSDP GH workflow"? #2638

gouttegd opened this issue Oct 10, 2024 · 2 comments

Comments

@gouttegd
Copy link
Collaborator

The data table for the cellPartOfAnatomicalEntity DOSDP pattern (src/patterns/data/default/cellPartOfAnatomicalEntity.tsv) is (and has always been) empty.

The custom Makefile contains a rule to fill that table from a GoogleDoc spreadsheet:

DOSDP_URL=https://docs.google.com/spreadsheets/d/e/2PACX-1vQpgUhGLXgSov-w4xu_7jaI-e5AS0MNLVVhd6omHBEh20UHcBbZHOM4m8lepzBPN4ErD6TjxaKRTX4A/pub?gid=0&single=true&output=tsv

.PRECIOUS: dosdp_%
dosdp_%:
       wget "$(DOSDP_URL)" -O ../patterns/data/default/$*.tsv

gs_dosdp: dosdp_cellPartOfAnatomicalEntity

However, that rule is never called from anywhere. Maybe it is supposed to be called manually by an editor from time to time, but if that’s the case that has never happened since the rule was put in place three years ago.

What is/was the intention here? Is the table supposed to be maintained/edited on GoogleDocs, and then imported in CL?

If only there was a way to document the intention behind your changes whenever you commit something to Git…

@matentzn
Copy link
Contributor

I found it; looks like this was supposed to be a way for people to start curating cl logical patterns in google sheets, but only a single line was added there:

https://docs.google.com/spreadsheets/d/1VmpTKYJL47qXiYCVPUhEWN841lxdQdxKy_2anO3-I_I/edit?gid=0#gid=0

This can be dropped IMO (or at least the wget, leaving the SOT in the repo)

@gouttegd
Copy link
Collaborator Author

OK, I’ll remove in the “Makefile cleanup” PR.

gouttegd added a commit that referenced this issue Oct 13, 2024
In the three years since the "DOSDP GH workflow" has been added to the
custom Makefile, (1) the workflow has never been invoked once, and (2)
only one row has ever been added to the remote spreadsheet.

This is clearly not used and can be removed. If people want to maintain
the pattern table on the remote spreadsheet, they can still do so, and
manually copy the rows to the TSV file in this repo.

closes #2638
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants