Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2528 - NTRs - externa and interna theca cells #2622

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

Caroline-99
Copy link
Collaborator

Fixes #2528

-Added two new terms - interna and exerna theca cells
-Added textual, logical defs, references and synonyms -imported uberon terms
-revised the logical and textual defs of theca cell

-Added two new terms - interna and exerna theca cells
-Added textual, logical defs, references and synonyms
-imported uberon terms
-revised the logical and textual defs of theca cells
@Caroline-99 Caroline-99 linked an issue Sep 30, 2024 that may be closed by this pull request
@Caroline-99 Caroline-99 self-assigned this Sep 30, 2024
@aleixpuigb
Copy link
Collaborator

#gogoeditdiff

Copy link

github-actions bot commented Sep 30, 2024

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-09-30/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-master.owl/cl-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-09-30/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-pr.owl/cl-simple.owl

Ontology imports

Ontology annotations

externa theca cell http://purl.obolibrary.org/obo/CL_4052013

Added

interna theca cell http://purl.obolibrary.org/obo/CL_4052012

Added

theca cell http://purl.obolibrary.org/obo/CL_0000503

Removed

Added

Copy link

github-actions bot commented Sep 30, 2024

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

externa theca cell http://purl.obolibrary.org/obo/CL_4052013

Added

interna theca cell http://purl.obolibrary.org/obo/CL_4052012

Added

theca cell http://purl.obolibrary.org/obo/CL_0000503

Removed

Added

theca externa http://purl.obolibrary.org/obo/UBERON_0000156

Added

theca interna http://purl.obolibrary.org/obo/UBERON_0000157

Added

@Caroline-99
Copy link
Collaborator Author

#gogoeditdiff

Copy link
Collaborator

@aleixpuigb aleixpuigb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, see inline comments

src/ontology/cl-edit.owl Show resolved Hide resolved
src/ontology/cl-edit.owl Show resolved Hide resolved
src/ontology/cl-edit.owl Show resolved Hide resolved
@Caroline-99 Caroline-99 merged commit f96ced6 into master Oct 1, 2024
1 check passed
@Caroline-99 Caroline-99 deleted the 2528-ntr-adding-subclasses-to-theca-cell branch October 1, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NTR] Adding subclasses to theca cell
2 participants