Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2672 - textual and logical defs - parietal cell #2681

Merged

Conversation

Caroline-99
Copy link
Collaborator

  • Revised textual defintion and add extra information in the comments section
  • Revised logical defs (Added + Updated GO links) + added links to uberon
  • Added references

- Revised textual defintion and add extra information in the comments section
- Revised logical defs ( Added + Updated GO links) + added links to uberon
-Added references
@Caroline-99 Caroline-99 linked an issue Oct 18, 2024 that may be closed by this pull request
@Caroline-99 Caroline-99 self-assigned this Oct 18, 2024
@Caroline-99
Copy link
Collaborator Author

#gogoeditdiff

Copy link

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-10-18/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-master.owl/cl-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-10-18/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-pr.owl/cl-simple.owl

Ontology imports

Ontology annotations

parietal cell http://purl.obolibrary.org/obo/CL_0000162

Removed

Added

Copy link

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

parietal cell http://purl.obolibrary.org/obo/CL_0000162

Removed

Added

Copy link
Collaborator

@JABelfiore JABelfiore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'fundic gastric gland' doesn't appear to be a commonly used term, please change to gastric gland (refers to glands in all parts of stomach)or fundic gland (refers to gland specifically in the fundus of the stomach). Everything else looks great!

@Caroline-99
Copy link
Collaborator Author

Caroline-99 commented Oct 24, 2024

'fundic gastric gland' doesn't appear to be a commonly used term, please change to gastric gland (refers to glands in all parts of stomach)or fundic gland (refers to gland specifically in the fundus of the stomach). Everything else looks great!

@JABelfiore I have just checked and there is no an uberon term for fundic gland. Fundic gland is used as a synonym to fundic gastric gland in Uberon and is defined as The fundus glands (or fundic glands, or gastric glands) are found in the body and fundus of the stomach. They are simple tubes, two or more of which open into a single duct. Would you be okay with me using the term fundic gastric gland? Or do you want me to change it to gastric gland ?

@JABelfiore
Copy link
Collaborator

'fundic gastric gland' doesn't appear to be a commonly used term, please change to gastric gland (refers to glands in all parts of stomach)or fundic gland (refers to gland specifically in the fundus of the stomach). Everything else looks great!

@JABelfiore I have just checked and there is no an uberon term for fundic gland. Fundic gland is used as a synonym to fundic gastric gland in Uberon and is defined as The fundus glands (or fundic glands, or gastric glands) are found in the body and fundus of the stomach. They are simple tubes, two or more of which open into a single duct. Would you be okay with me using the term fundic gastric gland? Or do you want me to change it to gastric gland ?

If its in uberon happy to keep as is

@JABelfiore JABelfiore self-requested a review October 24, 2024 10:38
@Caroline-99 Caroline-99 merged commit d304212 into master Oct 24, 2024
1 check passed
@Caroline-99 Caroline-99 deleted the 2672-text-def-revise-textual-and-logical-defs-parietal-cell branch October 24, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Text def] Revise textual and logical defs -parietal cell
2 participants