Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Switch to using OTel SDK for throughputmeasurement processor #1665

Merged
merged 5 commits into from
Jun 5, 2024

Conversation

BinaryFissionGames
Copy link
Contributor

Proposed Change

  • Swaps from the opencensus SDK to the otel SDK for throughput measurement
  • Remove the throughputwrapper
    • I was looking at this to maybe migrate to the OTel SDK, but I found that we don't actually use these metrics, and they add some complications outside of just being a component (it needs special service-level logic to work). Since we don't need it, I decided to remove it.
  • Add a test to ensure the metrics emitted by the processor is correct

I've tested this against bindplane:
Screenshot 2024-05-23 at 4 13 44 PM

This screenshot shows multiple sources funneling into one destination, with the metrics aggregating properly at the d0 node. You can also see that d1 is empty, due to a filter processor filtering all metrics.

Checklist
  • Changes are tested
  • CI has passed

@BinaryFissionGames BinaryFissionGames force-pushed the feat/use-otel-throughput branch 2 times, most recently from 8503e94 to a18ad45 Compare May 29, 2024 14:09
@BinaryFissionGames BinaryFissionGames changed the base branch from release/v1.52.0 to release/v1.53.0 May 29, 2024 14:09
@BinaryFissionGames BinaryFissionGames merged commit e503859 into release/v1.53.0 Jun 5, 2024
15 checks passed
@BinaryFissionGames BinaryFissionGames deleted the feat/use-otel-throughput branch June 5, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants