Update "Use Svelte in your plugin" for Svelte 4 #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this includes an upgrade to Typescript 5. This is working fine on my simple plugin but I'm not sure what kind of breaking changes might be lurking deeper down the stack.
|
Can confirm that these changes worked for me (typescript 5 and the changes in commit). |
|
These changes worked for me as well and resolved some confusion about how to add Svelte to the plugins, given that the Obsidian sample plugin code has changed ("6. Add Svelte to the list of plugins.") |
hemstreet
reviewed
Aug 7, 2024
| "include": [ "**/*.ts", "**/*.svelte" ] | ||
| ``` | ||
|
|
||
| 5. In `esbuild.config.mjs`, add the following imports to the top of the file: | ||
|
|
||
| ```js | ||
| import esbuildSvelte from "esbuild-svelte"; | ||
| import sveltePreprocess from "svelte-preprocess"; |
There was a problem hiding this comment.
This should be changed to import { sveltePreprocess } from 'svelte-preprocess'; as the current way it is, is a deprecated symbol.
It's shown here in the first code block below this header
|
@inhumantsar @hemstreet just confirming that this fixed svelte store issues that I was having as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this includes an upgrade to Typescript 5. This is working fine on my simple plugin but I'm not sure what kind of breaking changes might be lurking deeper down the stack.
Closes #92