Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nginx: Do not remove headers while proxying #14

Open
wants to merge 1 commit into
base: reflex-platform-20.09
Choose a base branch
from
Open

nixos/nginx: Do not remove headers while proxying #14

wants to merge 1 commit into from

Conversation

alexfmpe
Copy link

Removing the Accept-Encoding header breaks applications which may
produce already compressed content.

Removing this header is staded in the nginx docs but is ment as an
example, not as an recomendation.

(cherry picked from commit 762ca64)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alexfmpe alexfmpe changed the base branch from reflex-platform to reflex-platform-20.09 September 18, 2021 02:32
@alexfmpe alexfmpe changed the base branch from reflex-platform-20.09 to reflex-platform September 18, 2021 02:32
@fooker @alexfmpe
nixos/nginx: Do not remove headers while proxying
9c6fe6c 
Removing the `Accept-Encoding` header breaks applications which may
produce already compressed content.

Removing this header is staded in the nginx docs but is ment as an
example, not as an recomendation.

(cherry picked from commit 762ca64)
@alexfmpe alexfmpe changed the base branch from reflex-platform to reflex-platform-20.09 September 18, 2021 02:34
@alexfmpe alexfmpe removed the request for review from matthewbauer September 18, 2021 02:35
@alexfmpe
Copy link
Author

I believe this is no longer useful once reflex-frp/reflex-platform#768 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexfmpe @fooker