Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback for getting device path. #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dcnieho
Copy link

@dcnieho dcnieho commented May 14, 2021

Description

For various software devices i have, the devicePath remains empty upon DShow::Device::EnumVideoDevices(). I have implemented a fallback method for getting the devicepath.

Motivation and Context

I'd like to have device paths for as many devices, software or hardware, as possible.

How Has This Been Tested?

I have run enumDevices, called from my own application, and devicePaths for software devices are now created.
DShow::Device.SetVideoConfig() also works fine for a software device with this now non-empty path.

Types of changes

Unclear to me, seems to be a new feature.

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM
Copy link
Member

Are there specific devices where you ran into issues that we could verify with?

@dcnieho
Copy link
Author

dcnieho commented May 30, 2021

I have observed this with two devices, both https://obsproject.com/forum/resources/obs-virtualcam.949/, and the directshow adapter for Basler machine vision cameras (part of their Pylon runtime)--the latter you can't test without having a Basler camera i think. These are both software devices i guess.

@dcnieho
Copy link
Author

dcnieho commented Dec 27, 2022

Ping on this one. Its also how ffmpeg's dshow gets their device paths

@dcnieho
Copy link
Author

dcnieho commented Dec 27, 2022

And sorry to canabalize this PR, but i can't post issues to this repo. Is it being considered to re-apply 8f2ef91? I would love to have this functionality. Anything i can do to help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants