Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obs-webrtc: Various WHIP patches #10577

Merged
merged 3 commits into from
May 12, 2024
Merged

obs-webrtc: Various WHIP patches #10577

merged 3 commits into from
May 12, 2024

Conversation

tt2468
Copy link
Member

@tt2468 tt2468 commented Apr 21, 2024 •
edited
Loading

Description

  • Fixes ifdef guards for HEVC
  • Fixes a capitalization of a few comments
  • Only advertises relevant codecs in audio-only and video-only outputs

Motivation and Context

Clean things up and improve standards

How Has This Been Tested?

OBS compiles

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@tt2468 tt2468 changed the title obs-webrtc: Small patches for HEVC and comments obs-webrtc: Various WHIP patches Apr 23, 2024
RytoEX
RytoEX reviewed May 4, 2024
View reviewed changes
plugins/obs-webrtc/whip-service.cpp Outdated Show resolved Hide resolved
plugins/obs-webrtc/whip-output.cpp Show resolved Hide resolved
tt2468 added 3 commits May 4, 2024 19:44
@tt2468
obs-webrtc: Fix comment capitalization
3899911
@tt2468
obs-webrtc: Correctly guard HEVC in output using ifdefs
a2314ae 
If an output does not support HEVC, it should not advertise it. For
services, however, a service primarily defines the codecs which are
supported for the protocol spec itself/destination platform, so HEVC
can be advertised still.
@tt2468
obs-webrtc: Only advertise relevant codecs for a or v-only outputs
143acd6 
A video-only output should not advertise any audio codecs.
@RytoEX RytoEX merged commit 09be4f9 into obsproject:master May 12, 2024
14 checks passed
@RytoEX RytoEX added this to the OBS Studio (Next Version) milestone May 12, 2024
@RytoEX RytoEX added the Code Cleanup Non-breaking change which makes code smaller or more readable label May 12, 2024
@aler9 aler9 mentioned this pull request Jun 19, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lain-B Lain-B Lain-B approved these changes

@RytoEX RytoEX RytoEX approved these changes

Assignees
No one assigned
Labels
Code Cleanup Non-breaking change which makes code smaller or more readable
Projects
None yet
Milestone
OBS Studio 30.2
Development

Successfully merging this pull request may close these issues.
3 participants
@tt2468 @RytoEX @Lain-B