Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toc function back #240

Merged
merged 4 commits into from
Jun 24, 2021
Merged

Conversation

sonologico
Copy link
Collaborator

@sonologico sonologico commented May 23, 2021

Implementation is a simplified ported version of the one in 1.3.1.

Haven't tested it much yet.

Still missing

  • Testing it properly
  • Add tests
  • Add support for it to the CLI

@shonfeder
Copy link
Collaborator

looks good on first glance through! Thank you for picking this up 🙏

@tmattio tmattio mentioned this pull request Jun 23, 2021
3 tasks
@avsm avsm marked this pull request as ready for review June 24, 2021 13:22
@avsm
Copy link
Contributor

avsm commented Jun 24, 2021

I'll go ahead and merge this one, since @shonfeder has taken a look at it and @tmattio is using the functionality from this PR in the new "ocaml.org database" repository in https://github.com/ocaml/ood. @sonologico if you could contribute tests and so on in a future PR, that would be wonderful.

@avsm avsm merged commit b15996e into ocaml-community:master Jun 24, 2021
@shonfeder
Copy link
Collaborator

Thanks, @avsm !

mseri pushed a commit to ocaml/opam-repository that referenced this pull request Jun 25, 2021
CHANGES:

- Clean up AST representation (ocaml-community/omd#229, @sonologico)

- Restore table of contents generation functionality (ocaml-community/omd#240, @sonologico)

- Fix parsing of <...>-style links and inline code parsing (ocaml-community/omd#233, @SquidDev)

- Fix handing of the nonbreaking whitespace character, ASCII code 160 (ocaml-community/omd#247,
  @shonfeder)

- Downgrade dune requirements to 2.0 (@nobj)
@sonologico sonologico deleted the sonologico/toc branch July 3, 2021 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants