-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix test 206 #278
fix test 206 #278
Conversation
db52f84
to
07fe574
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could see the normalization function being in a separate file so that we have parser.ml
a bit more focused, but maybe it's not worth it for a single function.
03e6d09
to
bf2be7f
Compare
That's a good idea, @sonologico. Perhaps we could followup with a refactor to clean up that massive file at some point soon :) |
Will wait to review here until it's been rebased/updated to account for the work its based on. |
It's rebased 😊 |
Perfect, surgical fix here. We’ll diagnosed! Thanks :) |
CHANGES: - Expose the HTML escape function `htmlentities` (ocaml-community/omd#295 @cuihtlauac) - Support generation of identifiers in headers (ocaml-community/omd#294, @tatchi) - Support GitHub-Flavoured Markdown tables (ocaml-community/omd#292, @bobatkey) - Update parser to support CommonMark Spec 0.30 (ocaml-community/omd#266, @SquidDev) - Preserve the order of input files in the HTML output to stdout (ocaml-community/omd#258, @patricoferris) - Fix all deviations from CommonMark Spec 0.30 (ocaml-community/omd#284, ocaml-community/omd#283, ocaml-community/omd#278, ocaml-community/omd#277, ocaml-community/omd#269, @tatchi)
Input:
The current result in master:
There are two issues here:
Labels are not being matched, hence it is not recognized as a link. This is what I fixed in unicode link label normalization (fix test 539) #277. I included that change in the first commit.
The url destination is not percent encoded. From the spec:
And `ASCII control characters are:
I'm not sure why
'\x80' .. '\x9F'
were being matched since, according to the spec, they're not considered as an `ASCII control characters.Removing them from the pattern fixes the test and doesn't break any other so I guess that's fine.
Fix #272