Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #296
This moves the auto identifiers logic into the AST (when parsing the document). It moves the
auto_identifiers
parameter from theOmd.to_html
function to theOmd.{of_channel,of_string}
function.I'm not sure if this API is ideal because it means that we have to parse a document twice (once with
auto_identifiers
set totrue
and once withfalse
) if we want to print it with/without auto-identifiers.Perhaps including the auto-ids in the AST and deciding whether or not to include them at the time of printing would be a better solution.
The only problem is that we'd need to distinguish an explicit id from an auto-generated one in the AST.