OCaml 5.3 support #489
OCaml 5.3 support #489
Conversation
|
Looks at worst harmless in that it only impacts 5.3 and after. However, I think as part of this we should extend the CI to 5.3 since the CI didn't actually check that. |
src/lib/uTop_compat.ml
Outdated
| @@ -67,7 +67,28 @@ let rec is_persistent_path = function | |||
| #endif | |||
|
|
|||
| let invalid_package_error_to_string err = | |||
| #if OCAML_VERSION >= (5, 2, 0) | |||
| #if OCAML_VERSION >= (5,3,0) | |||
There was a problem hiding this comment.
this section can be nested in the original one. Only two lines are actually different
There was a problem hiding this comment.
I would suggest to define inline_code compatibility helper rather than deduplicate the full printer.
There was a problem hiding this comment.
I thought only the newest cppo had nesting support, so I avoided doing it. Am I wrong?
anmonteiro
force-pushed
the
anmonteiro/ocaml-5.3
branch
from
4f90e33
to
c7bab9e
Compare
|
Thanks for the helpful code review. The patch is way more minimal now. |
|
Okay, so what's next? |
|
it'd be nice for this to be merged and released so that we could release Reason with support for OCaml 5.3 soon. |
|
I'm happy to lend some time if utop needs more maintainers |
|
thanks for merging. would be nice to put together an opam release of utop compatible with OCaml 5.3 |
|
I will cut a release after the OCaml 5.3.0~beta1 and the 5.2.1 release (aka at the end of this week or next week). |
No description provided.