-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lin Out_channel shrink cleanup #387
Conversation
Oh wow 😮 linux-arm64 5.2 had a 16443.2s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! :-)
CI summary for f7223d6 from yesterday:
For the Cygwin failures, I get suspicious that the slowness is affecting the ability to trigger test failures and thereby cause needlessly long shrink runs 🤔 |
CI summary for bb94d34:
So 3/23 failures - but none of them being false positives! 😃 |
CI summary for b9509bb
So, 4/52 failures with only 1 of them being noise (Cygwin slowness is a genuine issue) and 1 being container related. I'll merge 😃 |
This PR contains a range of adjustments to address the long shrinking sequences reported in #378:
char
element shrinking insidebytes
andstring
s for the testlift
combinator to reduce allocationscmd
frequenciesflush_all
entirelyLin
allocations duringcheck_seq_cons
and should thus benefit otherLin
tests too.Overall, this makes the test behaviour reasonable. Below I include a CI summary table from running 20 focused tests across the 2 CI systems (I note runs taking more than 1000s as "outliers"). Observations:
perf
andolly gc-stats
measurementsOverall the PR offers improvements, not the final word. They should help reduce false CI alarms though.
The last two commits 460b97c and f7223d6 update the plain
Lin
Out_channel
test to move it closer feature-wise to theLin DSL
version. These are steps towards creating an standalone reproducer for the extra +5.1.0 GC activity.