Disable cmd shrinking for int64 ref Thread test #389
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing long
src/neg_tests/lin_tests_thread_ref.exe
causing timeouts and long runs, primarily on Cygwin part 2 (examples below).Since the experimental
Lin
Thread
mode does not produce test failures as consistently as theDomain
mode, this little PR disablescmd
argument shrinking for the test, to limit how many shrinking candidates we have to traverse.I've run focused tests which shows runs limited to at most 771.6s on Cygwin with the fix:
Interesting observation unrelated to this PR: the first (positive test) goes from 600-800s on
5.1
to about 1200s ontrunk
(which causes the former not to complete 20 iterations before the 6h timeout)Examples of timeouts and long runs:
timeout during
9221.8s Lin ref int64 test with Thread (shrinking: 22.0013)
long run
5144.7s Lin ref int64 test with Thread
timeout during
11039.8s Lin ref int64 test with Thread (shrinking: 50.0002)
long run
2381.5s Lin ref int64 test with Thread
timeout during
8343.3s Lin ref int64 test with Thread (shrinking: 38.0002)
long run
3214.6s Lin ref int64 test with Thread