Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable cmd shrinking for int64 ref Thread test #389

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Sep 4, 2023

We are seeing long src/neg_tests/lin_tests_thread_ref.exe causing timeouts and long runs, primarily on Cygwin part 2 (examples below).

Since the experimental Lin Thread mode does not produce test failures as consistently as the Domain mode, this little PR disables cmd argument shrinking for the test, to limit how many shrinking candidates we have to traverse.

I've run focused tests which shows runs limited to at most 771.6s on Cygwin with the fix:

Examples of timeouts and long runs:

@jmid
Copy link
Collaborator Author

jmid commented Sep 4, 2023

CI summary

That's 5 failures out of 55 (46+9) with only one being CI noise and no timeouts due to this PR.
I'll go ahead and merge.

@jmid jmid merged commit 8d3e82d into main Sep 4, 2023
44 of 47 checks passed
@jmid jmid deleted the lin-thread-no-shrink branch September 4, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant