Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run debug-runtime workflows with a reduced minor heap #403

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Nov 1, 2023

This little PR reduces the minor heap size of the debug-runtime workflows.
I'm expecting the reduced size to stress-test the GC-logic more than the default size.

The s=4096 words matches that of the ocaml/ocaml debug runtime workflow.

Finally, the reduced size was instrumental in triggering and reproducing the recently fixed assertion race condition.

@jmid
Copy link
Collaborator Author

jmid commented Nov 2, 2023

CI summary:

Out of 63 workflows 6 failed, with 5 genuine failures and 1 false positive

@jmid jmid merged commit 954e584 into main Nov 2, 2023
47 of 53 checks passed
@jmid jmid deleted the debug-runtime-reduced-minor-heap branch November 2, 2023 11:28
@jmid
Copy link
Collaborator Author

jmid commented Nov 2, 2023

CI summary for the merge to main: All green - 38 out of 38 runs succeeded!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant