Various fixes #179
Open
Various fixes #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the C sources rely on other files (usually headers) in other directories, then "c-libpaths" is used when building the target. OTOH, this will not help during the C dependency discovery, since the compiler is invoked without those, and thus it will fail. Hence, use the include paths for a target when running its C dependency discovery.
Nodes for C sources are added to the DAGs of each target using them, without creating any edge between these nodes and the targets. The result is that an OCaml linking task does not wait for all the C builds to finish, resulting in missing files halting the linking. Hence, set the proper edge between the CompileC node and the LinkTarget one, hopefully fixing the dependency. This also means the hack of waiting for the .o files is not needed anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the single PR, I realized it too late, and a couple of commits would conflict if sent in two PRs...
This series fixes two issues I found so far: