Fix varint decoding #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the test added fails with the current code. |
|
Thanks! |
|
@whitequark any chance we can get a new opam version! That would be awesome. Thanks |
|
A new version will be released after ppx_deriving 4.2 lands. |
gasche
added a commit
to gasche/opam-repository
that referenced
this pull request
Dec 2, 2017
* Support for NPM packaging (ocaml-ppx/ppx_deriving_protobuf#17) (Maxime Rasan) * Fix `varint` decoding (ocaml-ppx/ppx_deriving_protobuf#18) (There was a decoding bug for integers between 2^56 and 2^63) (Maxime Rasan) * Support for OCaml 4.06 (ocaml-ppx/ppx_deriving_protobuf#19) (Gabriel Scherer) The homepage for the project has now moved to: <https://github.com/ocaml-ppx/ppx_deriving_protobuf>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code fails to decode integers such as (3 << 56).