-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCaml 4.11 support #118
OCaml 4.11 support #118
Conversation
Signed-off-by: Rudi Grinberg <[email protected]>
Signed-off-by: Rudi Grinberg <[email protected]>
Signed-off-by: Rudi Grinberg <[email protected]>
Signed-off-by: Rudi Grinberg <[email protected]>
I've moved the commits from #111 for testing purpose and fixed a few issues there (cc @thierry-martinez @XVilka) However the CI failed in ppxlib on 4.11. @rgrinberg @xclerc have you ever seen this error message by any chance?
EDIT: nevermind I found the issue |
You have to drop also the 4.04 from the Travis, since new ppx_deriving-on-ppxlib supports only >=4.05. |
@@ -16,10 +16,8 @@ depends: [ | |||
"yojson" {>= "1.6.0" & < "2.0.0"} | |||
"result" | |||
"ppx_deriving" {>= "4.0" & < "5.0"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think also the new version restriction for ppx_deriving is required, since older versions wouldn't work.
I made minor review comments in #111, I don't know if they should be considered here or there. |
@kit-ty-kate let me know if I can help. I can continue work on this in the separate PR if you don't have time. |
Closing in favour of #121 |
Relies on ocaml-ppx/ppx_deriving#220