Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCaml 4.11 support #118

Closed
wants to merge 11 commits into from
Closed

OCaml 4.11 support #118

wants to merge 11 commits into from

Conversation

kit-ty-kate
Copy link
Collaborator

@kit-ty-kate kit-ty-kate commented May 1, 2020

@kit-ty-kate kit-ty-kate marked this pull request as ready for review May 6, 2020 14:29
@kit-ty-kate kit-ty-kate mentioned this pull request May 6, 2020
4 tasks
@kit-ty-kate
Copy link
Collaborator Author

kit-ty-kate commented May 6, 2020

I've moved the commits from #111 for testing purpose and fixed a few issues there (cc @thierry-martinez @XVilka)

However the CI failed in ppxlib on 4.11. @rgrinberg @xclerc have you ever seen this error message by any chance?

#=== ERROR while compiling ppxlib.0.13.0 ======================================#
# context              2.0.7 | linux/x86_64 | ocaml-variants.4.11.0+trunk | git+file:///home/opam/opam-repository
# path                 ~/.opam/ocaml-variants.4.11.0+trunk/.opam-switch/build/ppxlib.0.13.0
# command              ~/.opam/ocaml-variants.4.11.0+trunk/bin/dune build -p ppxlib -j 71
# exit-code            1
# env-file             ~/.opam/log/ppxlib-312-251322.env
# output-file          ~/.opam/log/ppxlib-312-251322.out
### output ###
# [...]
#     ocamldep traverse/.ppxlib_traverse.objs/ppxlib_traverse.pp.ml.d (exit 2)
# (cd _build/default && /home/opam/.opam/ocaml-variants.4.11.0+trunk/bin/ocamldep.opt -modules -impl traverse/ppxlib_traverse.pp.ml) > _build/default/traverse/.ppxlib_traverse.objs/ppxlib_traverse.pp.ml.d
# >> Fatal error: OCaml and preprocessor have incompatible versions
# Fatal error: exception Misc.Fatal_error

EDIT: nevermind I found the issue

@XVilka
Copy link

XVilka commented May 7, 2020

You have to drop also the 4.04 from the Travis, since new ppx_deriving-on-ppxlib supports only >=4.05.

@@ -16,10 +16,8 @@ depends: [
"yojson" {>= "1.6.0" & < "2.0.0"}
"result"
"ppx_deriving" {>= "4.0" & < "5.0"}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think also the new version restriction for ppx_deriving is required, since older versions wouldn't work.

@gasche
Copy link
Contributor

gasche commented May 9, 2020

I made minor review comments in #111, I don't know if they should be considered here or there.

@XVilka
Copy link

XVilka commented May 18, 2020

@kit-ty-kate let me know if I can help. I can continue work on this in the separate PR if you don't have time.

@thierry-martinez
Copy link
Contributor

I opened a new PR #121 to include @gasche's suggestions on #111 and with minor changes for better handling location information when possible (!Ast_helper.default_loc was used but never updated).

@kit-ty-kate
Copy link
Collaborator Author

Closing in favour of #121

@kit-ty-kate kit-ty-kate deleted the 411 branch May 22, 2020 22:05
gasche added a commit that referenced this pull request May 24, 2020
Port to ppxlib and OCaml 4.11 (continuation of #111 and #118)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants