4.05 support, bug fixes and a few minor functionality updates

[stevebleazard]

• 4.05 support
• add let _ = to_yojson / of_yojson to generated code to avoid warnings when they aren't used
• Fix bug where doing [@@deriving of_yojson] causes an unused rec warning
• Add support for keys function similar to Fields.name. Module Yojson_fields{_type} created with a keys value of a string list containing all the keys
• from_yojson_exn created to raise an exception rather than return an error

[gasche]

Could you split the separate changes in separate PRs? I think the 4.05 support is not the right approach -- #66 is better and should be merged soon, but it relies on changes on the side of ppx_deriving, but the other features should be considered on their own.

[gasche]

@stevebleazard the 4.05 support part of the patch is now obsolete (ppx_deriving.4.2.1 was released with a different API on 4.05 and 4.06). I would welcome your other changes, preferably split as separate commits in separate PRs. If you can't work of this, please let me know.

[stevebleazard]

Thanks, I'll take a look are splitting up the non-4.05 changes

…

On 21 November 2017 at 16:16, Gabriel Scherer ***@***.***> wrote: @stevebleazard <https://github.com/stevebleazard> the 4.05 support part of the patch is now obsolete. I would welcome your other changes, preferably split as separate commits in separate PRs. If you can't work of this, please let me know. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#67 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AXX2QIhPqyE7I_Mgs7_QbCi7hJnH6xm5ks5s4vd4gaJpZM4QiEmS> .