Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.06 support #62

Merged
merged 3 commits into from
Oct 24, 2017
Merged

4.06 support #62

merged 3 commits into from
Oct 24, 2017

Conversation

gasche
Copy link
Contributor

@gasche gasche commented Oct 24, 2017

This updates ppx_tools to compile correctly under 4.06.

(As I'm submitting this PR I realize that I may not have updated the lifter, I only fixed the build errors. I will look at it right now, so consider the PR as a work-in-progress for the next hour)

@alainfrisch
Copy link
Collaborator

alainfrisch commented Oct 24, 2017

I may not have updated the lifter

You mean, ast_lifter.ml? This file is generated by the build system, so this should be fine I think.

@gasche
Copy link
Contributor Author

gasche commented Oct 24, 2017

Ok, good news! (I'm not familiar with the ppx_tools internals.) So code-wise the present PR should be enough?

Travis CI fails because I did not touch the travis.yml file -- I noticed that the "right way" for it is to test 4.06 under an upstream 4.06 branch, and I will let the repo maintainer (you) do the branch-creation etc. But I should still have edited the file so that master uses 4.06(+beta2 for now?), correct? I will add an extra commit for this.

@gasche
Copy link
Contributor Author

gasche commented Oct 24, 2017

(thanks @avsm for the 4.06.0 dockerfiles, I was surprised to see they already exist.)

@gasche
Copy link
Contributor Author

gasche commented Oct 24, 2017

@alainfrisch travis now passes correctly. Is there anything else I need to do on my end?

@alainfrisch alainfrisch merged commit 21d1150 into ocaml-ppx:master Oct 24, 2017
@gasche
Copy link
Contributor Author

gasche commented Oct 24, 2017

Thanks! Eventually it would be helpful to have a ppx_tools release for 4.06. I can take care of the opam-repository publishing part if you want.

@alainfrisch
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants