Don't leak OMP's config through ppxlib's API #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Rebours <[email protected]>
NathanReb
force-pushed
the
hide-omp-config
branch
from
7899083
to
b6a0de6
Compare
ghost
approved these changes
Jun 29, 2020
|
This is extremely weird but I pushed an extra commit to my branch with the removal of the |
|
Github is having issues today. The CI results are going to be the same after adjusting the comment, so you can commit&push to master directly. |
NathanReb
added a commit
to NathanReb/opam-repository
that referenced
this pull request
Jul 8, 2020
CHANGES: - Bump ppxlib's AST to 4.10 (ocaml-ppx/ppxlib#130, @NathanReb) - Remove omp_config from `Expansion_context` and replace it with `tool_name` (ocaml-ppx/ppxlib#149, @NathanReb) - Change undocumented `Ppxlib.Driver.map_structure` to return a ppxlib's `structure` instead of a `Migrate_parsetree.Driver.some_structure`. (ocaml-ppx/ppxlib#153, @NathanReb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
Migrate_parestree.Driver.configfrom ppxlib's interface. We still expose thetool_nameas it's the only part of it that was used as far as I can tell. This change is required ahead of the future omp.2.0.0 release.