Add accessors for code_path and tool_name to Expansion_context.Base #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For code implemented using
e.g. `Ast_traverse.map_with_expansion_context`, there is a base
expansion context available, but no accessors for e.g. the `code_path`
within. A hacky workaround is to write e.g.
```ocaml
let code_path base =
Expansion_context.Extension.code_path
(Expansion_context.Extension.make
~extension_point_loc:Location.none ~base ())
```
This patch adds accessors to directly obtain these values without such
a detour.
Signed-off-by: Josh Berdine <[email protected]>
NathanReb
approved these changes
Sep 8, 2020
NathanReb
added a commit
to NathanReb/opam-repository
that referenced
this pull request
Sep 17, 2020
CHANGES: - Add accessors for `code_path` and `tool_name` to `Expansion_context.Base` (ocaml-ppx/ppxlib#173, @jberdine) - Add `cases` methods to traversal classes in `Ast_traverse` (ocaml-ppx/ppxlib#183, @pitag-ha)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For code implemented using
e.g.
Ast_traverse.map_with_expansion_context, there is a baseexpansion context available, but no accessors for e.g. the
code_pathwithin. A hacky workaround is to write e.g.
This patch adds accessors to directly obtain these values without such
a detour.