Add error_extensionf in the API to ease the process of embedding errors
#316
Conversation
panglesd
requested review from
ceastlund,
NathanReb and
pitag-ha
as code owners
panglesd
changed the title
error_extensionf in the API to ease the process of embedding errorserror_extensionf in the API to ease the process of embedding errors
|
Oh, and one more thing: we should also edit the documentation of |
|
Sure! I added a changelog entry and updated the doc. When this PR and the #318 PR are merged, there should be a link from the API of those functions to the relevant part of the manual. The maintenance of this link would be eased if the manual was written using |
CHANGES.md
Outdated
| @@ -19,6 +19,8 @@ | |||
| consider a type declaration recursive if the type appeared inside an attribute | |||
| payload (#299, @NathanReb) | |||
|
|
|||
| - Added `error_extensionf` function to the `Locate` module (#316, @panglesd) | |||
There was a problem hiding this comment.
| - Added `error_extensionf` function to the `Locate` module (#316, @panglesd) | |
| - Added `error_extensionf` function to the `Location` module (#316, @panglesd) |
Also, similarly to here: would you mind rebasing over main and moving this entry up to the unreleaed section (it's currently in the section of the last release).
Signed-off-by: Paul-Elliot <[email protected]>
Signed-off-by: Paul-Elliot <[email protected]>
Signed-off-by: Paul-Elliot <[email protected]>
Signed-off-by: Paul-Elliot <[email protected]>
Signed-off-by: Paul-Elliot <[email protected]>
Signed-off-by: Paul-Elliot <[email protected]>
Signed-off-by: Paul-Elliot <[email protected]>
panglesd
force-pushed
the
api-for-extension-nodes
branch
from
a6f68d5
to
1f6e53c
Compare
Signed-off-by: Paul-Elliot <[email protected]>
CHANGES: - Added `error_extensionf` function to the `Location` module (ocaml-ppx/ppxlib#316, @panglesd) - Ast patterns: add `drop` and `as` patterns (ocaml-ppx/ppxlib#313 by @Kakadu, review by @pitag-ha) - Fixed a bug resulting in disscarded rewriters in the presence of instrumentations, as well as a wrong order of rewriting (ocaml-ppx/ppxlib#296, @panglesd) - Driver: Append the last valid AST to the error in case of located exception when embedding errors (ocaml-ppx/ppxlib#315, @panglesd)
This is part of the #314 tasks.
The examples are updated to embed errors using the new function, instead of raising located errors.