Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vendored dependency #385

Closed
wants to merge 1 commit into from
Closed

Conversation

panglesd
Copy link
Collaborator

Remove vendored ppx_sexp_conv and add it as normal dependency for ppxlib-bench.

Signed-off-by: Paul-Elliot <[email protected]>
@avsm
Copy link

avsm commented Feb 14, 2023

Yes please! The vendoring here also breaks the build of ppxlib in a bigger dune monorepo (where it'll conflict with another version of ppx_sexp_conv elsewhere).

@pitag-ha
Copy link
Member

Thanks, @panglesd, for the quick PR! To be clear: this breakage is on me.

Notice that if we treat the benchmark PPX as a normal dependency, we'll benchmark some ppxlib release (as opposed to its dev version). It's possible that we could find a way around that, but @kit-ty-kate has already found a different great solution to the problem: #386. It's already merged and patch released.

@panglesd panglesd closed this Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants