Expose migration/copying/etc. functions for all AST types needed by Pprintast
#454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antalsz
force-pushed
the
expose-everything
branch
from
b2cd130
to
57e13dc
Compare
ceastlund
approved these changes
Aug 10, 2023
|
Looks like it needs a changelog entry, can you add one? Otherwise, once the CI signs off on the tests, looks good to me. |
Signed-off-by: Antal Spector-Zabusky <[email protected]>
antalsz
force-pushed
the
expose-everything
branch
from
57e13dc
to
142d35c
Compare
|
Done, I used the PR title |
Signed-off-by: Antal Spector-Zabusky <[email protected]>
antalsz
force-pushed
the
expose-everything
branch
2 times, most recently
from
5240684
to
601b702
Compare
Signed-off-by: Antal Spector-Zabusky <[email protected]>
antalsz
force-pushed
the
expose-everything
branch
from
601b702
to
bc23863
Compare
avsm
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Oct 5, 2023
CHANGES: - Fix support for OCaml 5.1: migrated code preserves generative functor warnings, without creating more. Locations are better preserved. (ocaml-ppx/ppxlib#432, @pitag-ha, @panglesd) - Driver: Add `-unused-code-warnings` command-line flag. (ocaml-ppx/ppxlib#444, @ceastlund) - Add `?warning` flag to `Deriving.Generator.make`. (ocaml-ppx/ppxlib#440, @jacksonzou123 via @ceastlund) - Restore the "path_arg" functionality in the V3 API (ocaml-ppx/ppxlib#431, @ELLIOTTCABLE) - Expose migration/copying/etc. functions for all AST types needed by `Pprintast` (ocaml-ppx/ppxlib#454, @antalsz) - Preserve quoted attributes on antiquotes in metaquot (ocaml-ppx/ppxlib#441, @ncik-roberts) - Attribute namespaces: Fix semantics of reserving multi-component namespaces (ocaml-ppx/ppxlib#443, @ncik-roberts)
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES: - Fix support for OCaml 5.1: migrated code preserves generative functor warnings, without creating more. Locations are better preserved. (ocaml-ppx/ppxlib#432, @pitag-ha, @panglesd) - Driver: Add `-unused-code-warnings` command-line flag. (ocaml-ppx/ppxlib#444, @ceastlund) - Add `?warning` flag to `Deriving.Generator.make`. (ocaml-ppx/ppxlib#440, @jacksonzou123 via @ceastlund) - Restore the "path_arg" functionality in the V3 API (ocaml-ppx/ppxlib#431, @ELLIOTTCABLE) - Expose migration/copying/etc. functions for all AST types needed by `Pprintast` (ocaml-ppx/ppxlib#454, @antalsz) - Preserve quoted attributes on antiquotes in metaquot (ocaml-ppx/ppxlib#441, @ncik-roberts) - Attribute namespaces: Fix semantics of reserving multi-component namespaces (ocaml-ppx/ppxlib#443, @ncik-roberts)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves some cinaps stuff around, but otherwise is just a widening of the exposed APIs -- no new functionality is defined (except for a few new identity functions for the 4.14 <-> 5.00 nonmigration).
The motivation for this is that we would like to be able to link up
Pprintastwith the flambda-backend pretty-printer, and this requires the broader API surface area this PR exposes; to be clear, though, this PR doesn't do anything flambda-backend specific.