Skip to content

dev meeting 20210311

Jump to bottom
Sonja Heinze edited this page Mar 11, 2021 · 1 revision

Present at the meeting:

  • Jérémie Dimino (@jeremiedimino)
  • Sonja Heinze (@pitag-ha)

Current plan

  • Sonja removes the last use of Misc and rebases Astlib again
  • We merge Astlib
  • Sonja reduces the Astlib API a bit more

Meeting notes

Sonja has removed the internal Lexer module step by step. She's sent a patch to the two libraries who are affected by that.

By removing the Lexer module, we've gotten rid of one of the uses of compiler-lib's Misc. Another use case of Misc was its word distance function for the spell checker. Sonja has inlined it. There is one last use of Misc: protect_refs in Ast_helper. Sonja will copy in the compiler-libs definition.

About Ast_helper: quite a few downstream users use it. So it needs to stay in the public API and can't be moved into scr/gen/. For now, we leave it where it is (in Ppxlib_ast), but it will go into the local Astlib.

The internal copy of Pprintast is in a similar situation: Sonja has tried to remove it, but Pprintast is broken on old (<4.08) compiler versions, which is causing some tests on the CI to fail on old compilers and might be a problem for downstream users. So for now, it stays where it is and eventually it will go into the local Astlib.

Once all uses of Misc are removed, the next step will be to merge Astlib and to keep on reducing its API.

Clone this wiki locally