Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steps towards MSVC support #157

Merged
merged 5 commits into from
Sep 9, 2024
Merged

Steps towards MSVC support #157

merged 5 commits into from
Sep 9, 2024

Conversation

dra27
Copy link
Member

@dra27 dra27 commented Sep 8, 2024

I have managed to build Zarith using GMP from vcpkg and make tests passes. It'll take a bit longer to work out how to package that up in opam, but here are the initial patches to Zarith.

I've changed configure to generate Makefile.config instead of Makefile so that the results can be shared easily with tests/Makefile. This can obviously be done differently.

The other changes I think are relatively self-explanatory. I didn't double-check, but I have a feeling that \r in a sed RE is a GNU-ism, but tr -d '\r' is definitely POSIX.

Copy link
Contributor

@xavierleroy xavierleroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I agree that a Makefile that includes a generated Makefile.config is works better here. @antoinemine , are you OK with that?

@antoinemine
Copy link
Collaborator

Yes, this is fine for me too! Thanks for the patch.

@xavierleroy xavierleroy merged commit 29cc486 into ocaml:master Sep 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants