Fix destruct crashing on closed variant types #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voodoos
changed the title
voodoos
added a commit
to voodoos/merlin
that referenced
this pull request
May 26, 2023
from voodoos/repro-issue-1601
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
May 26, 2023
CHANGES:
Fri May 26 15:23:42 CEST 2023
+ merlin binary
- Allow monadic IO in dot protocol (ocaml/merlin#1581)
- Add a `scope` option to the `occurrences` command in preparation for
the upcoming `project-wide-occurrences` feature (ocaml/merlin#1596)
- Construct bool-typed holes as `false` instead of `true` in the
`construct` command, for consistency (ocaml/merlin#1599).
- Add a hook to configure system command for spawning ppxes when Merlin is
used as a library. (ocaml/merlin#1585)
- Implement an all-or-nothing cache for the PPX phase (ocaml/merlin#1584)
- Cleanup functors caches when backtracking, to avoid memory leaks
(ocaml/merlin#1609, fixes ocaml/merlin#1529 and ocaml-lsp#1032)
- Fix `construct` results ordering for sum types sand poly variants (ocaml/merlin#1603)
- Fix object method completion not working (ocaml/merlin#1606, fixes ocaml/merlin#1575)
- Improve context detection for package types (ocaml/merlin#1608, fixes ocaml/merlin#1607)
- Fix incorrect locations for string literals (ocaml/merlin#1574)
- Fixed an issue that caused `errors` to erroneously alert about missing
`cmi` files (ocaml/merlin#1577)
- Prevent destruct from crashing on closed variant types (ocaml/merlin#1602,
fixes ocaml/merlin#1601)
- Improve longident parsing (ocaml/merlin#1612, fixes ocaml/merlin#945)
+ editor modes
- emacs: call the user's configured completion UI in
`merlin-construct` (ocaml/merlin#1598)
+ test suite
- Add missing dependency to a test using ppxlib (ocaml/merlin#1583)
- Add tests for the new PPX phase cache (ocaml/merlin#1584)
- Add and update tests for `construct` ordering (ocaml/merlin#1603)
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
May 26, 2023
CHANGES:
Fri May 26 15:23:42 CEST 2023
+ merlin binary
- Allow monadic IO in dot protocol (ocaml/merlin#1581)
- Add a `scope` option to the `occurrences` command in preparation for
the upcoming `project-wide-occurrences` feature (ocaml/merlin#1596)
- Construct bool-typed holes as `false` instead of `true` in the
`construct` command, for consistency (ocaml/merlin#1599).
- Add a hook to configure system command for spawning ppxes when Merlin is
used as a library. (ocaml/merlin#1585)
- Implement an all-or-nothing cache for the PPX phase (ocaml/merlin#1584)
- Cleanup functors caches when backtracking, to avoid memory leaks
(ocaml/merlin#1609, fixes ocaml/merlin#1529 and ocaml-lsp#1032)
- Fix `construct` results ordering for sum types sand poly variants (ocaml/merlin#1603)
- Fix object method completion not working (ocaml/merlin#1606, fixes ocaml/merlin#1575)
- Improve context detection for package types (ocaml/merlin#1608, fixes ocaml/merlin#1607)
- Fix incorrect locations for string literals (ocaml/merlin#1574)
- Fixed an issue that caused `errors` to erroneously alert about missing
`cmi` files (ocaml/merlin#1577)
- Prevent destruct from crashing on closed variant types (ocaml/merlin#1602,
fixes ocaml/merlin#1601)
- Improve longident parsing (ocaml/merlin#1612, fixes ocaml/merlin#945)
+ editor modes
- emacs: call the user's configured completion UI in
`merlin-construct` (ocaml/merlin#1598)
+ test suite
- Add missing dependency to a test using ppxlib (ocaml/merlin#1583)
- Add tests for the new PPX phase cache (ocaml/merlin#1584)
- Add and update tests for `construct` ordering (ocaml/merlin#1603)
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
May 26, 2023
CHANGES:
Fri May 26 15:23:42 CEST 2023
+ merlin binary
- Allow monadic IO in dot protocol (ocaml/merlin#1581)
- Add a `scope` option to the `occurrences` command in preparation for
the upcoming `project-wide-occurrences` feature (ocaml/merlin#1596)
- Construct bool-typed holes as `false` instead of `true` in the
`construct` command, for consistency (ocaml/merlin#1599).
- Add a hook to configure system command for spawning ppxes when Merlin is
used as a library. (ocaml/merlin#1585)
- Implement an all-or-nothing cache for the PPX phase (ocaml/merlin#1584)
- Cleanup functors caches when backtracking, to avoid memory leaks
(ocaml/merlin#1609, fixes ocaml/merlin#1529 and ocaml-lsp#1032)
- Fix `construct` results ordering for sum types sand poly variants (ocaml/merlin#1603)
- Fix object method completion not working (ocaml/merlin#1606, fixes ocaml/merlin#1575)
- Improve context detection for package types (ocaml/merlin#1608, fixes ocaml/merlin#1607)
- Fix incorrect locations for string literals (ocaml/merlin#1574)
- Fixed an issue that caused `errors` to erroneously alert about missing
`cmi` files (ocaml/merlin#1577)
- Prevent destruct from crashing on closed variant types (ocaml/merlin#1602,
fixes ocaml/merlin#1601)
- Improve longident parsing (ocaml/merlin#1612, fixes ocaml/merlin#945)
+ editor modes
- emacs: call the user's configured completion UI in
`merlin-construct` (ocaml/merlin#1598)
+ test suite
- Add missing dependency to a test using ppxlib (ocaml/merlin#1583)
- Add tests for the new PPX phase cache (ocaml/merlin#1584)
- Add and update tests for `construct` ordering (ocaml/merlin#1603)
[new release] merlin, merlin-lib and dot-merlin-reader (4.9-414)
CHANGES:
Fri May 26 15:23:42 CEST 2023
+ merlin binary
- Allow monadic IO in dot protocol (ocaml/merlin#1581)
- Add a `scope` option to the `occurrences` command in preparation for
the upcoming `project-wide-occurrences` feature (ocaml/merlin#1596)
- Construct bool-typed holes as `false` instead of `true` in the
`construct` command, for consistency (ocaml/merlin#1599).
- Add a hook to configure system command for spawning ppxes when Merlin is
used as a library. (ocaml/merlin#1585)
- Implement an all-or-nothing cache for the PPX phase (ocaml/merlin#1584)
- Cleanup functors caches when backtracking, to avoid memory leaks
(ocaml/merlin#1609, fixes ocaml/merlin#1529 and ocaml-lsp#1032)
- Fix `construct` results ordering for sum types sand poly variants (ocaml/merlin#1603)
- Fix object method completion not working (ocaml/merlin#1606, fixes ocaml/merlin#1575)
- Improve context detection for package types (ocaml/merlin#1608, fixes ocaml/merlin#1607)
- Fix incorrect locations for string literals (ocaml/merlin#1574)
- Fixed an issue that caused `errors` to erroneously alert about missing
`cmi` files (ocaml/merlin#1577)
- Prevent destruct from crashing on closed variant types (ocaml/merlin#1602,
fixes ocaml/merlin#1601)
- Improve longident parsing (ocaml/merlin#1612, fixes ocaml/merlin#945)
+ editor modes
- emacs: call the user's configured completion UI in
`merlin-construct` (ocaml/merlin#1598)
+ test suite
- Add missing dependency to a test using ppxlib (ocaml/merlin#1583)
- Add tests for the new PPX phase cache (ocaml/merlin#1584)
- Add and update tests for `construct` ordering (ocaml/merlin#1603)
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
May 31, 2023
CHANGES:
unreleased
+ merlin binary
- Preview support for OCaml 5.1-alpha1. Short path is temporary disabled and
inline records might not behave as expected.
- Allow monadic IO in dot protocol (ocaml/merlin#1581)
- Add a `scope` option to the `occurrences` command in preparation for
the upcoming `project-wide-occurrences` feature (ocaml/merlin#1596)
- Construct bool-typed holes as `false` instead of `true` in the
`construct` command, for consistency (ocaml/merlin#1599).
- Add a hook to configure system command for spawning ppxes when Merlin is
used as a library. (ocaml/merlin#1585)
- Implement an all-or-nothing cache for the PPX phase (ocaml/merlin#1584)
- Cleanup functors caches when backtracking, to avoid memory leaks
(ocaml/merlin#1609, fixes ocaml/merlin#1529 and ocaml-lsp#1032)
- Fix `construct` results ordering for sum types sand poly variants (ocaml/merlin#1603)
- Fix object method completion not working (ocaml/merlin#1606, fixes ocaml/merlin#1575)
- Improve context detection for package types (ocaml/merlin#1608, fixes ocaml/merlin#1607)
- Fix incorrect locations for string literals (ocaml/merlin#1574)
- Fixed an issue that caused `errors` to erroneously alert about missing
`cmi` files (ocaml/merlin#1577)
- Prevent destruct from crashing on closed variant types (ocaml/merlin#1602,
fixes ocaml/merlin#1601)
- Improve longident parsing (ocaml/merlin#1612, fixes ocaml/merlin#945)
+ editor modes
- emacs: call the user's configured completion UI in
`merlin-construct` (ocaml/merlin#1598)
+ test suite
- Add missing dependency to a test using ppxlib (ocaml/merlin#1583)
- Add tests for the new PPX phase cache (ocaml/merlin#1584)
- Add and update tests for `construct` ordering (ocaml/merlin#1603)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIxes issue #1601