Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] ppx_deriving (5.0) #17512

Merged
merged 3 commits into from
Oct 27, 2020

Conversation

kit-ty-kate
Copy link
Member

Type-driven code generation for OCaml

CHANGES:

@camelus
Copy link
Contributor

camelus commented Oct 26, 2020

Commit: a50d626

Good to see you Madam.

☀️ All lint checks passed a50d626
  • These packages passed lint tests: ppx_deriving.5.0

☀️ Installability check (+1)
  • new installable packages (1): ppx_deriving.5.0

@mseri
Copy link
Member

mseri commented Oct 27, 2020

There are just two revdeps failures.
The first seems just to be incompatible (maybe just with the compiler ast version)

#=== ERROR while compiling yices2_bindings.0.1 ================================#
# context              2.0.7 | linux/x86_64 | ocaml-base-compiler.4.11.1 | file:///home/opam/opam-repository
# path                 ~/.opam/4.11/.opam-switch/build/yices2_bindings.0.1
# command              /usr/bin/make
# exit-code            2
# env-file             ~/.opam/log/yices2_bindings-26-358891.env
# output-file          ~/.opam/log/yices2_bindings-26-358891.out
### output ###
# ocamlbuild -use-ocamlfind test_gmp src/yices2_bindings.cma src/yices2_bindings.cmxa src/META
# ocamlfind ocamlopt unix.cmxa -I /home/opam/.opam/4.11/lib/ocamlbuild /home/opam/.opam/4.11/lib/ocamlbuild/ocamlbuildlib.cmxa -linkpkg myocamlbuild.ml /home/opam/.opam/4.11/lib/ocamlbuild/ocamlbuild.cmx -o myocamlbuild
# ocamlfind ocamlc -g -c gmp.c
# ocamlfind ocamldep -package ctypes -package ctypes.foreign -package sexplib -package containers -package ppx_deriving.std -package ppx_optcomp -modules src/yices2_header.ml > src/yices2_header.ml.depends
# ocamlfind ocamldep -package ctypes -package ctypes.foreign -package sexplib -package containers -package ppx_deriving.std -package ppx_optcomp -modules src/yices2_low_types.ml > src/yices2_low_types.ml.depends
# ocamlfind ocamldep -package ctypes -package ctypes.foreign -package sexplib -package containers -package ppx_deriving.std -package ppx_optcomp -modules src/yices2_high_types.ml > src/yices2_high_types.ml.depends
# ocamlfind ocamldep -package ctypes -package ctypes.foreign -package sexplib -package containers -package ppx_deriving.std -package ppx_optcomp -modules src/yices2_low.mli > src/yices2_low.mli.depends
# ocamlfind ocamlc -c -g -annot -bin-annot -package zarith -package ctypes-zarith -package ctypes -package ctypes.foreign -package sexplib -package containers -package ppx_deriving.std -package ppx_optcomp -I src -o src/yices2_low_types.cmo src/yices2_low_types.ml
# ocamlfind ocamlc -c -g -annot -bin-annot -package zarith -package ctypes-zarith -package ctypes -package ctypes.foreign -package sexplib -package containers -package ppx_deriving.std -package ppx_optcomp -I src -o src/yices2_low.cmi src/yices2_low.mli
# ocamlfind ocamldep -package ctypes -package ctypes.foreign -package sexplib -package containers -package ppx_deriving.std -package ppx_optcomp -modules src/yices2_low.ml > src/yices2_low.ml.depends
# ocamlfind ocamlc -c -g -annot -bin-annot -package zarith -package ctypes-zarith -package ctypes -package ctypes.foreign -package sexplib -package containers -package ppx_deriving.std -package ppx_optcomp -I src -o src/yices2_header.cmo src/yices2_header.ml
# ocamlfind ocamldep -package ctypes -package ctypes.foreign -package sexplib -package containers -package ppx_deriving.std -package ppx_optcomp -modules src/yices2_high.mli > src/yices2_high.mli.depends
# ocamlfind ocamlc -c -g -annot -bin-annot -package zarith -package ctypes-zarith -package ctypes -package ctypes.foreign -package sexplib -package containers -package ppx_deriving.std -package ppx_optcomp -I src -o src/yices2_high_types.cmo src/yices2_high_types.ml
# ocamlfind ocamlc -c -g -annot -bin-annot -package zarith -package ctypes-zarith -package ctypes -package ctypes.foreign -package sexplib -package containers -package ppx_deriving.std -package ppx_optcomp -I src -o src/yices2_high.cmi src/yices2_high.mli
# ocamlfind ocamldep -package ctypes -package ctypes.foreign -package sexplib -package containers -package ppx_deriving.std -package ppx_optcomp -modules src/yices2_high.ml > src/yices2_high.ml.depends
# ocamlfind ocamldep -package ctypes -package ctypes.foreign -package sexplib -package containers -package ppx_deriving.std -package ppx_optcomp -modules src/yices2_ext_bindings.mli > src/yices2_ext_bindings.mli.depends
# ocamlfind ocamlc -c -g -annot -bin-annot -package zarith -package ctypes-zarith -package ctypes -package ctypes.foreign -package sexplib -package containers -package ppx_deriving.std -package ppx_optcomp -I src -o src/yices2_ext_bindings.cmi src/yices2_ext_bindings.mli
# ocamlfind ocamldep -package ctypes -package ctypes.foreign -package sexplib -package containers -package ppx_deriving.std -package ppx_optcomp -modules src/yices2_ext_bindings.ml > src/yices2_ext_bindings.ml.depends
# ocamlfind ocamldep -package ctypes -package ctypes.foreign -package sexplib -package containers -package ppx_deriving.std -package ppx_optcomp -modules src/yices2_SMT2.mli > src/yices2_SMT2.mli.depends
# ocamlfind ocamlc -c -g -annot -bin-annot -package zarith -package ctypes-zarith -package ctypes -package ctypes.foreign -package sexplib -package containers -package ppx_deriving.std -package ppx_optcomp -I src -o src/yices2_SMT2.cmi src/yices2_SMT2.mli
# ocamlfind ocamldep -package ctypes -package ctypes.foreign -package sexplib -package containers -package ppx_deriving.std -package ppx_optcomp -modules src/yices2_SMT2.ml > src/yices2_SMT2.ml.depends
# ocamlfind ocamlc -c -g -annot -bin-annot -package zarith -package ctypes-zarith -package ctypes -package ctypes.foreign -package sexplib -package containers -package ppx_deriving.std -package ppx_optcomp -I src -o src/yices2_low.cmo src/yices2_low.ml
# ocamlfind ocamlc -c -g -annot -bin-annot -package zarith -package ctypes-zarith -package ctypes -package ctypes.foreign -package sexplib -package containers -package ppx_deriving.std -package ppx_optcomp -I src -o src/yices2_high.cmo src/yices2_high.ml
# ocamlfind ocamlc -c -g -annot -bin-annot -package zarith -package ctypes-zarith -package ctypes -package ctypes.foreign -package sexplib -package containers -package ppx_deriving.std -package ppx_optcomp -I src -o src/yices2_ext_bindings.cmo src/yices2_ext_bindings.ml
# + ocamlfind ocamlc -c -g -annot -bin-annot -package zarith -package ctypes-zarith -package ctypes -package ctypes.foreign -package sexplib -package containers -package ppx_deriving.std -package ppx_optcomp -I src -o src/yices2_ext_bindings.cmo src/yices2_ext_bindings.ml
# File "src/yices2_ext_bindings.ml", line 22, characters 64-67:
# 22 |   | List l -> Format.fprintf fmt "@[<hv 1>(%a)@]" (List.pp ~sep:" " pp_sexp) l
#                                                                      ^^^
# Error: The function applied to this argument has type
#          ?pp_start:unit List.printer ->
#          ?pp_stop:unit List.printer ->
#          ?pp_sep:unit List.printer ->
#          Format.formatter -> 'weak2 List.t -> unit
# This argument cannot be applied with label ~sep
# Command exited with code 2.
# make: *** [Makefile:6: build] Error 10

the other I think has lost a transitive dependency. I don't think adding it as a dependency will fix the issue, most likely it was not really linked against explicitly:

#=== ERROR while compiling cconv.0.4 ==========================================#
# context              2.0.7 | linux/x86_64 | ocaml-base-compiler.4.11.1 | file:///home/opam/opam-repository
# path                 ~/.opam/4.11/.opam-switch/build/cconv.0.4
# command              ~/.opam/4.11/.opam-switch/build/cconv.0.4/./configure --disable-yojson --disable-bencode --disable-sexp --enable-ppx --disable-tests --disable-docs
# exit-code            1
# env-file             ~/.opam/log/cconv-25-a3393d.env
# output-file          ~/.opam/log/cconv-25-a3393d.out
### output ###
# File "./setup.ml", line 1404, characters 23-41:
# 1404 |          let compare = Pervasives.compare
#                               ^^^^^^^^^^^^^^^^^^
# Alert deprecated: module Stdlib.Pervasives
# Use Stdlib instead.
# 
# If you need to stay compatible with OCaml < 4.07, you can use the 
# stdlib-shims library: https://github.com/ocaml/stdlib-shims
# File "setup.ml", line 3252, characters 16-34:
# Alert deprecated: module Stdlib.Pervasives
# Use Stdlib instead.
# 
# If you need to stay compatible with OCaml < 4.07, you can use the 
# stdlib-shims library: https://github.com/ocaml/stdlib-shims
# ocamlfind: Package `ppx_tools.metaquot' not found
# W: Field 'pkg_ppx_tools_metaquot' is not set: Command ''/home/opam/.opam/4.11/bin/ocamlfind' query -format %d ppx_tools.metaquot > '/tmp/oasis-a7a5ec.txt'' terminated with error code 2
# E: Cannot find findlib package ppx_tools.metaquot
# E: Failure("1 configuration error")

@kit-ty-kate
Copy link
Member Author

All green now.

@kit-ty-kate kit-ty-kate merged commit 91a8243 into ocaml:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants