Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] yaml and yaml-sexp (3.1.0) #21023

Merged
merged 3 commits into from
Mar 27, 2022

Conversation

samoht
Copy link
Member

@samoht samoht commented Mar 27, 2022

Parse and generate YAML 1.1/1.2 files

CHANGES:

CHANGES:

* Support MSVC with .obj and .lib extensions, and defining
  -DDYAML_DECLARE_EXPORT (@jonahbeckford avsm/ocaml-yaml#53)

* Upgrade to dune 2 (@TheLortex, avsm/ocaml-yaml#54)

* Add ocamlformat (@samoht, avsm/ocaml-yaml#55)

* Make yaml compatible with opam-monorepo (@TheLortex, avsm/ocaml-yaml#56)
@samoht
Copy link
Member Author

samoht commented Mar 27, 2022

The irmin-unix tests should be fixed by #21025
The minimal bound fix has been backported upstream here: avsm/ocaml-yaml#58

This fixes:

```
-     ocamlopt unix/.yaml_unix.objs/native/yaml_unix.{cmx,o} (exit 2)
- (cd _build/default && /home/opam/.opam/4.13/bin/ocamlopt.opt -w -40 -w -9-27-32 -g -I unix/.yaml_unix.objs/byte -I unix/.yaml_unix.objs/native -I /home/opam/.opam/4.13/lib/astring -I /home/opam/.opam/4.13/lib/bos -I /home/opam/.opam/4.13/lib/bytes -I /home/opam/.opam/4.13/lib/ctypes -I /home/opam/.opam/4.13/lib/fmt -I /home/opam/.opam/4.13/lib/fpath -I /home/opam/.opam/4.13/lib/integers -I /home/opam/.opam/4.13/lib/logs -I /home/opam/.opam/4.13/lib/result -I /home/opam/.opam/4.13/lib/rresult -I ffi/bindings/.yaml_bindings.objs/byte -I ffi/bindings/.yaml_bindings.objs/native -I ffi/lib/.yaml_ffi.objs/byte -I ffi/lib/.yaml_ffi.objs/native -I lib/.yaml.objs/byte -I lib/.yaml.objs/native -I types/bindings/.yaml_bindings_types.objs/byte -I types/bindings/.yaml_bindings_types.objs/native -I types/lib/.yaml_types.objs/byte -I types/lib/.yaml_types.objs/native -I vendor/.yaml_c.objs/byte -I vendor/.yaml_c.objs/native -intf-suffix .ml -no-alias-deps -o unix/.yaml_unix.objs/native/yaml_unix.cmx -c -impl unix/yaml_unix.ml)
- File "unix/yaml_unix.ml", line 17, characters 16-27:
- 17 | let of_file f = Result.bind (OS.File.read f) Yaml.of_string
-                      ^^^^^^^^^^^
- Error: Unbound value Result.bind
```
@samoht
Copy link
Member Author

samoht commented Mar 27, 2022

(not totally sure about the conflict with < 1.5, but Result.bind is throwing an error if result is installed)

@samoht samoht merged commit 54f724d into ocaml:master Mar 27, 2022
@samoht samoht deleted the release-yaml-v3.1.0 branch March 27, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant