-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new release] ppxlib (0.27.0) #21532
Conversation
CHANGES: - Update expansion context to leave out value name when multiple are defined at once. (ocaml-ppx/ppxlib#351, @ceastlund) - Add support for OCaml 5.0 (ocaml-ppx/ppxlib#348, @pitag-ha) - Add `Code_path.enclosing_value` (ocaml-ppx/ppxlib#349, @ceastlund) - Add `Code_path.enclosing_module` (ocaml-ppx/ppxlib#346, @ceastlund) - Expand code generated by `~enclose_intf` and `~enclose_impl` (ocaml-ppx/ppxlib#345, @ceastlund) - Add type annotations to code generated by metaquot (ocaml-ppx/ppxlib#344, @ceastlund) - Fix typo in description field of dune-project (ocaml-ppx/ppxlib#343, @ceastlund) - Fix Ast_pattern.many (ocaml-ppx/ppxlib#333, @nojb) - Fix quoter and optimize identifier quoting (ocaml-ppx/ppxlib#327, @sim642) - Driver, when run with `--check`: Allow `toplevel_printer` attributes (ocaml-ppx/ppxlib#340, @pitag-ha) - Documentation: Add a section on reporting errors by embedding extension nodes in the AST (ocaml-ppx/ppxlib#318, @panglesd) - Driver: In the case of ppxlib internal errors, embed those errors instead of raising to return a meaningful AST (ocaml-ppx/ppxlib#329, @panglesd) - API: For each function that could raise a located error, add a function that return a `result` instead (ocaml-ppx/ppxlib#329, @panglesd)
metaquot seems to have broken a few packages:
From my limited ppx knowledge, this new expected type seems weird to me. |
That appears to be the nonsensical use of metaquot as mentioned in ocaml-ppx/ppxlib#344:
|
Both PPXs are using metaquot faultly at one place. From ppxlib.0.27.0 on, metaquot catches that kind of misuse.
Yes, in metaquot direct anti-quotation + quotation, used to be too polymorphic and both PD: I'll also backport 5.0 support to an older ppxlib then (tomorrow) to make sure the whole PPX ecosystem supports 5.0. |
Thanks |
Standard library for ppx rewriters
CHANGES:
Update expansion context to leave out value name when multiple are
defined at once. (Updated expansion context to include value names only when unambiguous. ocaml-ppx/ppxlib#351, @ceastlund)
Add support for OCaml 5.0 (Add 5.0 support ocaml-ppx/ppxlib#348, @pitag-ha)
Add
Code_path.enclosing_value
(Added Code_path.enclosing_value ocaml-ppx/ppxlib#349, @ceastlund)Add
Code_path.enclosing_module
(implementing Code_path.enclosing_module ocaml-ppx/ppxlib#346, @ceastlund)Expand code generated by
~enclose_intf
and~enclose_impl
(Expand header and footer from enclose_intf and enclose_impl ocaml-ppx/ppxlib#345, @ceastlund)Add type annotations to code generated by metaquot (Annotate types of metaquot generated code. ocaml-ppx/ppxlib#344, @ceastlund)
Fix typo in description field of dune-project (Update dune-project description to match ppxlib.opam description. ocaml-ppx/ppxlib#343, @ceastlund)
Fix Ast_pattern.many (Fix Ast_pattern.many ocaml-ppx/ppxlib#333, @nojb)
Fix quoter and optimize identifier quoting (Fix and optimize quoter ocaml-ppx/ppxlib#327, @sim642)
Driver, when run with
--check
: Allowtoplevel_printer
attributes (Allow toplevel_printer attributes ocaml-ppx/ppxlib#340, @pitag-ha)Documentation: Add a section on reporting errors by embedding extension nodes
in the AST (Update of the manual to document error reporting ocaml-ppx/ppxlib#318, @panglesd)
Driver: In the case of ppxlib internal errors, embed those errors instead of
raising to return a meaningful AST (Prefer embedding to raising when possible ocaml-ppx/ppxlib#329, @panglesd)
API: For each function that could raise a located error, add a function that
return a
result
instead (Prefer embedding to raising when possible ocaml-ppx/ppxlib#329, @panglesd)